Aggregates ignore ordering about pg-aggregates HOT 6 CLOSED

Yeah going to do just that.

from pg-aggregates.

Wrapping the table expression has a couple disadvantages:

• It's likely to perform less well in some circumstances
• It needs to be select my_table.* from my_table ... and select my_table.* will break queries for people using column-level select grants

Instead, it would need to be done in the aggregates themselves.

This is not something I'm particularly interested in taking on right now, but if you wanted to take a punt at it along with the accompanying tests (and make sure the tests pass against PG10-14) and benchmark, that would give a significant leg up to this being something that we could merge. And even if we didn't merge it, you could use your custom plugin with PostGraphile, so your work would not be in vain 👍

from pg-aggregates.

It's likely to perform less well in some circumstances

True, still I think the one who wants ordering is willing to take a trade-off instead of not having it at all.

It needs to be select my_table.* from my_table ... and select my_table.* will break queries for people using column-level select grants

🤔 never had the chance to use that feature of postgres.

Instead, it would need to be done in the aggregates themselves.

Yeah that is probably the most straightforward way, tho some people advice against it when you have more than one aggregate (they have something about it in the thread). Still better than no ordering at all IMO.

I'm very limited about the time I can spend on that, probably I won't be able to make right proper PR.

from pg-aggregates.

You're probably best forking this plugin and adding in the more direct logic yourself; that wouldn't be merged into this project for the reasons outlined, but it may suffice for your needs 👍

from pg-aggregates.

@benjie Is the any way to get a result of addArgDataGenerator for given type, from some hook? I'm trying to add ordering to AddConnectionGroupedAggregatesPlugin other way but copy-pasting that. I've added orderBy arg to AggregateContainerType typed with table's orderBy type (e.g. MatchesOrderBy to MatchAggregates), but I cannot get original SQL query building function for the ordering type. I've tried to look for a way to get pgQuery function from runtime stuff available to the field hook, but no luck. The closest thing I see is fieldArgDataGeneratorsByFieldNameByType, but all values there are just empty objects.

from pg-aggregates.

I don't really know; I'd have to spend some time figuring that out - I've not worked in the lookahead engine for a while and it's... not obvious 😉

from pg-aggregates.