granitedevices / simplemotionv2 Goto Github PK

CFGConnectingDFUModeFailed is only used in smFirmwareUpload. I propose to rename it to FWConnectingDFUModeFailed, move it to the other enum and give it a new value. Currently one cannot distinguish one error condition from the other as they both have the same value.

There's a bug in indexing the data buffer in readFileLine: https://github.com/GraniteDevices/SimpleMotionV2/blob/master/devicedeployment.c#L47

The index should be *readPosition, not *readPosition+len.

SimpleMotionV2 is not able to compile in Qt or any other IDE, please see attached image

warning C4005: 'CM_NONE': macro redefinition
Both simplemotion and wingdi.h:2157 #define CM_NONE
Both defines are 0, so that is nice. :)

There are free CI tools available for open source projects. These tools can be used to check that your code is compiling on multiple platforms and that there are no warnings generated. It also makes it unnecessary to have your own hardware and development tools for all of these platforms.

Popular choices are Travis CI for building on Linux and macOS and AppVeyor for building on Windows. Both services have good integration with GitHub.

Taking these services into use is not a big thing. Write some settings files, have some build scripts and start coding. You can see an example in my fork: https://github.com/oswjk/SimpleMotionV2/commits/travis

The example I posted above builds SimpleMotionV2 for Linux, macOS and Windows x86/x64, so four platforms are compiled on each commit.

What are you thoughts about this?

Passing a const variable as the array size is not supported in MSVC (or in C). The fix is to use a #define or an enum for the maxLineLen value. This feature is supported when compiling in C++ mode, but then there are other compilation problems.

This affects both master and develop branches.