Upgrade all Build Tool to use Docker >= 24.x.x about agones HOT 11 OPEN

Then let's just focus on xonotic and simple-game-server for now.

from agones.

There is - we should also change everything in /build - but let's tackle that after the next release as it's a bigger chunk of work we'll want to coordinate together.

from agones.

Coming off review of #3531 (comment) - @Kalaiselvi84 highlighted two things to note:

• DOCKER_CLI_EXPERIMENTAL=enabled should be removed from all commands, since it's no longer needed
• Where you see docker buildx create --name=$(BUILDX_WINDOWS_BUILDER) --use while not 100% necessary, I think it would be better to remove the --use so it's not set as the default for all future builds, and instead be explicit in our docker buildx build commands with the --builder argument.

Example of using --build can be found here:

Although in this example, we still need to remove --use and the DOCKER_CLI_EXPERIMENTAL parts of the commands.

Lemme know if any of that doesn't make sense.

from agones.

Tried without --use and DOCKER_CLI_EXPERIMENTAL=enabled, but the build for simple-game-server failed: https://gist.github.com/Kalaiselvi84/38a273a6dbb7e308fdb4be166fc597fd

from agones.

Can you push the changes, so I can see what your cloudbuild.yaml actually looks like -- hard to debug without it 😄

from agones.

Committed the changes.👍🏻

Log without DOCKER_CLI_EXPERIMENTAL=enabled and with --use: https://gist.github.com/Kalaiselvi84/0d0b5fcc8de6fb9f31ac0d8588f40fda

from agones.

@markmandel, should we focus only on xonotic and simple-game-server, or include all example images? If we include all, shall I submit a PR for the rest? I've updated the Docker image to version 24.0.6 in all the CloudBuild scripts. Almost all builds have succeeded, the build for c++ is still running.

from agones.

Honestly, I was only going to worry about it for those examples that had multi architecture manifests (such as Xonotic) - but it probably doesn't hurt to standardise accepts the board.

from agones.

Both xonotic and simple-game-server PRs have been merged. May I know if there are any further tasks required for this issue?

from agones.

Next steps for this 🎉:

• Update /cloudbuild.yaml, and fix what breaks (exactly as you did previously).

  • agones/cloudbuild.yaml

    Line 30 in 1e78d88

    - name: gcr.io/cloud-builders/docker

  • agones/cloudbuild.yaml

    Line 69 in 1e78d88

    - "echo 'FROM gcr.io/cloud-builders/docker\nRUN apt-get install make\nENTRYPOINT\

Note: After the above work is merged, anyone on Docker 20.x will need to update.

Before release, we'll also need to update the release process:

• agones/build/release/post_cloudbuild.yaml

  Line 63 in 1e78d88

  - "echo 'FROM gcr.io/cloud-builders/docker\nRUN apt-get install make\nENTRYPOINT\

Once this is done, it might also be worth going through any other cloudbuild scripts looking for references to gcr.io/cloud-builders/docker and align everything on gcr.io/cloud-builders/docker:24.0.6 to make everything consistent.

from agones.

Found another file that needs updating:

@gongmax - sorry looks like we broke your performance test CI.

from agones.