gameServerSetCacheEntry doesn`t return updated gs about agones HOT 7 OPEN

Thanks for filing this issue.

Are you able to provide context on what the user issue is here with Agones, and how to reproduce it.

Unfortunately I'm not sure if we have enough actionable information here to action this ticket.

from agones.

In fact, I didn`t meet any trouble coused by this. I just thought the code here did something obviouslly different from the comment. Even if it really coused instant unconsistency, i thought it wil be fixed eventually. Just misleading code.

from agones.

Agreed, the comment is confusing - I didn't write the code but I think the point was to return the GameServer with the deletion timestamp when initially set in the cache, rather than when it ultimately hit the Kubernetes control pane.

Not sure if practically it makes any difference.

If you change the code, does anything break?

from agones.

I made the change to my fork and saw nothing wrong these days.
After reading the logics again before and after these lines, I think this will make any real difference.

from agones.

I made the change to my fork and saw nothing wrong these days.

Do the unit and integration tests pass?

from agones.

Sorry, may I ask you how to do unit and integration tests? Is there a document I can read?

from agones.

https://github.com/googleforgames/agones/blob/main/build/README.md

from agones.