Comments (3)
Not sure about using that to map the OpenRTB field. The problem is that the OpenRTB spec requires MNC codes, but our CSV doesn't include that... outside the US this gets messier, you need two codes (MCC + MNC) unless I map only the MNC and assume that users will use that as a compound key with the country from geo info. (And I wouldn't bet there's a 1:1 relationship of country:MCC.) Anyway AdX doesn't provide either MCCs or MNCs anywhere in the protocol or mapping files. But it makes sense to have this CSV loaded by DoubleClickMetadata
to help users that don't want to deal with Google's carrier IDs.
Mobile app categories are a harder problem, we don't yet have a mapping table from the Google Play categories to IAB, this may take more time... the spreadsheet was filled in a bit optimistically for this field, for now I'm annotating it to make clear this is planned by not implemented yet.
from openrtb-doubleclick.
Check out e1ca649
from openrtb-doubleclick.
I've reviewed the OpenRTB spec and it says this about carriers:
carrier - string - Carrier or ISP (e.g., “VERIZON”). “WIFI” is often used in mobile to indicate high bandwidth (e.g., video friendly vs. cellular).
I agree that MNC + MCC code would be the best way to inform about the carrier, but in the meantime I think it's nearer to the standard to have the carrier name instead of the google carrier ID.
Thank you very much for the changes!
from openrtb-doubleclick.
Related Issues (20)
- DoubleClickCrypto not really threadsafe? HOT 4
- How to send response back to Adx from OpenRtb.BidResponse.Builder HOT 19
- Latest 1.3.1 release doesn't have DoubleClickOpenRtbMapper and other related mappers HOT 5
- billing_id in openrtb json is String and not Long HOT 6
- Incorrectly mapped device.geo.lat and lon HOT 2
- BidExtWriter and BidExtReader lacks support for 'attribute' field. HOT 3
- Upgrading to support openrtb-adx.proto v28 HOT 3
- [com.google.doubleclick.imp] how to change to "ext" in BidRequest HOT 1
- Imp.Pmp.DealExt no Extension in openrtb-doubleclick
- How to change format from json to protobuf when send response back to doubleclick ?
- Deal Object Extension
- want '{}' but I give [] in response (seatbid and bid params) ?use python send protobuf openrtb data
- Changelog information missing HOT 1
- maven-download-plugin CachedFileEntry issue. Fix or add description to ReadMe HOT 1
- How can I use doubleblick-core 1.5.16
- Timeline for the doubleblick-openrtb 1.5.16 maven release HOT 1
- Timeline for 2.0.2 (SKAdNetwork)
- [Docs] Possible outdated documentation HOT 1
- add support for golang decode price examples HOT 1
- DoubleClickMetadata automatic use HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openrtb-doubleclick.