Comments (6)
Thanks for this report -- this is a bug indeed, what happens is that DoubleClick's billing_id
is a long so this code needs to make a conversion but it's doing it wrong, it should be using getValueAsLong()
instead of getLongValue()
. Will fix this immediately.
from openrtb-doubleclick.
Thank you. There are also other fields in the Imp Ext that have the same issue, publisher list id, etc.
from openrtb-doubleclick.
Argh, I see now why this bug wasn't caught by the tests. The billing_id
is a long
and real-world values are often above JSON/JavasScript's limit of maximum representable integer (2^53 - 1), so JSON serializers often have an extension to quote large integer numbers. We use that in AdX, but we use it only for values above this limit, 12345678901 is not big enough, and we shouldn't have billing_id
s that exceed 2^53 so this wouldn't even be a bug technically. But I suppose you maye have some intermediary processing between AdX and your bidder, and some JSON serializers have different behaviors, for one thing even our own public Protobuf 3 will always quote longs. So I'm still going to improve the library to allow quoted longs there, but let me know how are you getting this bid request message, if it's coming straight from AdX I may need to chase that too.
from openrtb-doubleclick.
yes, making the same change for publisher_settings_list_id
.
from openrtb-doubleclick.
This issue still persists. Steps to reproduce:
- Receive bid request via PROTOCOL_OPENRTB_PROTOBUF_2_3 protocol.
- Read received protobuff request to BidRequest object via parseFrom:
ExtensionRegistry dcExtension = ExtensionRegistry.newInstance(); AdxExt.registerAllExtensions(dcExtension); OpenRtb.BidRequest openRtbRequest = OpenRtb.BidRequest.parseFrom(data, dcExtension);
- Print received JSON:
OpenRtbJsonFactory dcJsonFactory = AdxExtUtils.registerAdxExt(OpenRtbJsonFactory.create()); String jsonOutput = dcJsonFactory.newWriter().writeBidRequest(openRtbRequest);
from openrtb-doubleclick.
Sorry for the confusion, I had closed the bug but not released the fix yet. I have just pushed the fix to the master repository here, please test again after pulling the latest code from head.
from openrtb-doubleclick.
Related Issues (20)
- DoubleClickCrypto not really threadsafe? HOT 4
- How to send response back to Adx from OpenRtb.BidResponse.Builder HOT 19
- Latest 1.3.1 release doesn't have DoubleClickOpenRtbMapper and other related mappers HOT 5
- Incorrectly mapped device.geo.lat and lon HOT 2
- BidExtWriter and BidExtReader lacks support for 'attribute' field. HOT 3
- Upgrading to support openrtb-adx.proto v28 HOT 3
- [com.google.doubleclick.imp] how to change to "ext" in BidRequest HOT 1
- Imp.Pmp.DealExt no Extension in openrtb-doubleclick
- How to change format from json to protobuf when send response back to doubleclick ?
- Deal Object Extension
- want '{}' but I give [] in response (seatbid and bid params) ?use python send protobuf openrtb data
- Changelog information missing HOT 1
- maven-download-plugin CachedFileEntry issue. Fix or add description to ReadMe HOT 1
- How can I use doubleblick-core 1.5.16
- Timeline for the doubleblick-openrtb 1.5.16 maven release HOT 1
- Timeline for 2.0.2 (SKAdNetwork)
- [Docs] Possible outdated documentation HOT 1
- add support for golang decode price examples HOT 1
- DoubleClickMetadata automatic use HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openrtb-doubleclick.