Comments (4)
opinali
commented on May 4, 2024
You are right, this was a bad change... years ago so it's hard to remember/track if the racy random was intentional, it's not a big deal because we don't need a high quality rng here (not using SecureRandom for this reason), this method is mostly useful for tests since bidders never need to encrypt things. But there's certainly no motivation to make any sacrifice for correctness here, and if the racy random was desired we could just use a regular Random. I'm fixing this now. Thanks!
from openrtb-doubleclick.
aeneid
commented on May 4, 2024
I can provide a PR if you prefer
from openrtb-doubleclick.
opinali
commented on May 4, 2024
No need thanks, I just merged a commit for this, planning to release tomorrow.
from openrtb-doubleclick.
opinali
commented on May 4, 2024
Done, v1.2.3.
from openrtb-doubleclick.
Related Issues (20)
- How to send response back to Adx from OpenRtb.BidResponse.Builder HOT 19
- Latest 1.3.1 release doesn't have DoubleClickOpenRtbMapper and other related mappers HOT 5
- billing_id in openrtb json is String and not Long HOT 6
- Incorrectly mapped device.geo.lat and lon HOT 2
- BidExtWriter and BidExtReader lacks support for 'attribute' field. HOT 3
- Upgrading to support openrtb-adx.proto v28 HOT 3
- [com.google.doubleclick.imp] how to change to "ext" in BidRequest HOT 1
- Imp.Pmp.DealExt no Extension in openrtb-doubleclick
- How to change format from json to protobuf when send response back to doubleclick ?
- Deal Object Extension
- want '{}' but I give [] in response (seatbid and bid params) ?use python send protobuf openrtb data
- Changelog information missing HOT 1
- maven-download-plugin CachedFileEntry issue. Fix or add description to ReadMe HOT 1
- How can I use doubleblick-core 1.5.16
- Timeline for the doubleblick-openrtb 1.5.16 maven release HOT 1
- Timeline for 2.0.2 (SKAdNetwork)
- [Docs] Possible outdated documentation HOT 1
- add support for golang decode price examples HOT 1
- DoubleClickMetadata automatic use HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openrtb-doubleclick.