Comments (4)
You are correct, the problem is that the canonical name provides the State as the immediate parent of postal codes, thee's no city in-between like one would expect. I supposed that postal codes might not always be exclusive to cities; but then, there's no problem in the sequence of parent geo_criteria_id
's, in this case the first parent is 1015214 = Tampa. Unfortunately we don't use that sequence of IDs for building the child-parent relationships because, according to our documentation, "This field is included for legacy support, and the IDs may not be consistent across datasets. Canonical Names is the preferred method of constructing hierarchies." Let me investigate this.
from openrtb-doubleclick.
Upon some extra investigation... the easiest way to fix this is by supporting both parent chains; here's what I'm doing: link the GeoTarget
objects by both the canonical names and parent IDs, with separate pointers; provide APIs that allow to lookup the "parent/ancestor by canonical name" or "parent/ancestor by parent ID". The OpenRTB mapper can then try both chains, with priority for the canonical chain because it's the supported/recommended/best-quality data, but if we don't find what you want there then a result based on the parent ID chain is certainly more useful than nothing.
from openrtb-doubleclick.
Implemented initially in this development fork:
opinali@b5eb2c4
from openrtb-doubleclick.
Done 53b9e63
from openrtb-doubleclick.
Related Issues (20)
- DoubleClickCrypto not really threadsafe? HOT 4
- How to send response back to Adx from OpenRtb.BidResponse.Builder HOT 19
- Latest 1.3.1 release doesn't have DoubleClickOpenRtbMapper and other related mappers HOT 5
- billing_id in openrtb json is String and not Long HOT 6
- Incorrectly mapped device.geo.lat and lon HOT 2
- BidExtWriter and BidExtReader lacks support for 'attribute' field. HOT 3
- Upgrading to support openrtb-adx.proto v28 HOT 3
- [com.google.doubleclick.imp] how to change to "ext" in BidRequest HOT 1
- Imp.Pmp.DealExt no Extension in openrtb-doubleclick
- How to change format from json to protobuf when send response back to doubleclick ?
- Deal Object Extension
- want '{}' but I give [] in response (seatbid and bid params) ?use python send protobuf openrtb data
- Changelog information missing HOT 1
- maven-download-plugin CachedFileEntry issue. Fix or add description to ReadMe HOT 1
- How can I use doubleblick-core 1.5.16
- Timeline for the doubleblick-openrtb 1.5.16 maven release HOT 1
- Timeline for 2.0.2 (SKAdNetwork)
- [Docs] Possible outdated documentation HOT 1
- add support for golang decode price examples HOT 1
- DoubleClickMetadata automatic use HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openrtb-doubleclick.