Git Product home page Git Product logo

Comments (4)

opinali avatar opinali commented on May 4, 2024

You are correct, the problem is that the canonical name provides the State as the immediate parent of postal codes, thee's no city in-between like one would expect. I supposed that postal codes might not always be exclusive to cities; but then, there's no problem in the sequence of parent geo_criteria_id's, in this case the first parent is 1015214 = Tampa. Unfortunately we don't use that sequence of IDs for building the child-parent relationships because, according to our documentation, "This field is included for legacy support, and the IDs may not be consistent across datasets. Canonical Names is the preferred method of constructing hierarchies." Let me investigate this.

from openrtb-doubleclick.

opinali avatar opinali commented on May 4, 2024

Upon some extra investigation... the easiest way to fix this is by supporting both parent chains; here's what I'm doing: link the GeoTarget objects by both the canonical names and parent IDs, with separate pointers; provide APIs that allow to lookup the "parent/ancestor by canonical name" or "parent/ancestor by parent ID". The OpenRTB mapper can then try both chains, with priority for the canonical chain because it's the supported/recommended/best-quality data, but if we don't find what you want there then a result based on the parent ID chain is certainly more useful than nothing.

from openrtb-doubleclick.

opinali avatar opinali commented on May 4, 2024

Implemented initially in this development fork:
opinali@b5eb2c4

from openrtb-doubleclick.

opinali avatar opinali commented on May 4, 2024

Done 53b9e63

from openrtb-doubleclick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.