Cannot return RuntimeError from native function about go-jsonnet HOT 6 CLOSED

Pinging @sbarzowski as requested.

from go-jsonnet.

Specifically, camh wants to return an error from a NativeCallback and there's only the regular error return there. I'm not sure if it even has support for RuntimeError or whether it just treats everything as an internal error.

from go-jsonnet.

Ah. It's a mistake, thanks for finding it. The idea was to always wrap this error as a runtime error. (And if you really want to crash with an internal error you can just panic - this will also cause a stack trace to be included).

Here's a pull request which fixes that: #165 (no tests at the moment, I'll try to add some later).

from go-jsonnet.

LGTM. I wrote a test if you want it, here: camh-@4ff0363

from go-jsonnet.

@camh- Cool! Of course I want it :-). Please send a pull request (directly to google/go-jsonnet).

from go-jsonnet.

Pull request #166 sent. It is based on master so the tests will be failing until #165 is merged.

from go-jsonnet.