Comments (6)
@sbarzowski would know better but I think we didn't make it thread safe at all. It might be possible to put locks throughout the VM. I think our reasoning was that the language itself was single threaded so there was no point allowing a VM to process two executions at once. What if you wrapped the whole thing in a single global lock, or just serialised your interactions with it?
from go-jsonnet.
That would mean we undo any gain we get from concurrently generating, which is very significant.
from go-jsonnet.
If the gains you got were from cacheing then you'd still get those gains on account of the cache being maintained between runs
from go-jsonnet.
That's separate, we both run generation per "stack" concurrently, and when we did that we saw an additional improvement when using the same runtime. We could write our own importer, but if the rest of the runtime is not concurrency safe then it's of little use.
from go-jsonnet.
I see.
Any chance you can look at go race detector to see if it's only a small number of places that need protecting?
Another option might be to create n VMs but have them all accessing the same import cache, which is a smaller unit of code to protect.
from go-jsonnet.
I can't believe I haven't thought of that, agreed, go race detector should be able to catch this with sufficient amounts of iterations. Will try!
from go-jsonnet.
Related Issues (20)
- Go implementation missing a new line to generated yaml files
- super[<expr>] fails when expr is not a variable reference
- inconsistent/invalid parsing behavior on block strings HOT 12
- Unable to find valid certification path to requested target while running bazel test
- Is `v0.20.0` the latest release? HOT 2
- add unit tests for `add_plus_object.go , enforce_comment_style.go and enforce_max_blanck_lines.go` HOT 1
- jsonnet-lint missing std.all and std.any
- jsonnet-lint missing std.reverse
- jsonnet-lint missing std.objectKeysValues HOT 1
- parseYaml panics when passed empty string
- gazelle naming convention changes
- Decimal number displayed differently
- Need help building the c-bindings
- jsonnetfmt cli tool could support a canonical mode
- [Question] Parser package, children function
- std.splitLimitR is missing from go-jsonnet
- Support for stdlib context (cancellation / timeouts)
- Interest for import toml ?
- Buggy field visibility handling in`objectHas` in Go impl
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-jsonnet.