Git Product home page Git Product logo

Comments (12)

sparkprime avatar sparkprime commented on May 19, 2024

"blank line" was intended to mean "line with no characters at all" so the spec is ambiguous there.

from go-jsonnet.

sparkprime avatar sparkprime commented on May 19, 2024

So the reason these are working is that the indentation level is chosen as w = 2 (actually since we have to handle a mix of tabs and spaces it's expressed as w = " ") and then that's stripped off every line until you see a ||| without w on the front.

from go-jsonnet.

sparkprime avatar sparkprime commented on May 19, 2024

I'll write your examples again but with . for the space character and not . for arbitrary text:

|||
..
.. test
..|||,
.. ||| x
|||
|||
..
.. test
.. |||,
.. ||| x
|||

from go-jsonnet.

sparkprime avatar sparkprime commented on May 19, 2024

What's bad about this is the number of spaces on the first line (even though the line only has spaces on it) will change the amount of indentation that is stripped off of the remaining lines. But this is what meaningful whitespace is all about, I'm not sure anything can be done about that.

from go-jsonnet.

nicklan avatar nicklan commented on May 19, 2024

Thanks for the reply.

(edit: previous text here was incorrect, removing)

from go-jsonnet.

nicklan avatar nicklan commented on May 19, 2024

Ohh, I think actually I understand now. The spec is really difficult to read here. But basically because those lines begin with .., they don't end the block.

The block only ends if it has LESS or DIFFERENT whitespace at the start. Is that correct?

from go-jsonnet.

sparkprime avatar sparkprime commented on May 19, 2024

Yeah that's right. I will update the spec and it's probably worth having some examples in the language reference too.

from go-jsonnet.

nicklan avatar nicklan commented on May 19, 2024

Got it, thanks. Feel free to close this then, or maybe only after you update the spec ;)

from go-jsonnet.

nicklan avatar nicklan commented on May 19, 2024

One more thing to note, the ending behavior should probably also specify "ends at the first NON-BLANK subsequent line that does not begin with W", since adding "blank" lines in the middle of a block seems to work fine. (or that's a bug if not intended)

from go-jsonnet.

sparkprime avatar sparkprime commented on May 19, 2024

True, and you can also have blank lines at the end I think (just before the final |||)

from go-jsonnet.

sbarzowski avatar sbarzowski commented on May 19, 2024

I suppose we could clarify the spec here.

from go-jsonnet.

sparkprime avatar sparkprime commented on May 19, 2024

google/jsonnet#1061

from go-jsonnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.