Comments (2)
goetas
commented on September 24, 2024
hmm... weird. will have a look soon!
from twital.
abcarroll
commented on September 24, 2024
I have a patch, which I created by carefully replicating the 'sandboxing' used in the BlockNode code. Can you take a look at it when you get a chance, and let me know if this looks correct?
To be totally honest, I don't understand why it's necessary to use the sandboxing but seemed like a logical fix, to insert a temporary 'buffer' node.
Here is the commit:
abcarroll@f10c5a2
If it looks correct, I'll rebase it into a single commit and open a PR, if that sounds good to you. I may add some additional tests over the weekend if I have time as well.
Also, I have a few other small patches: there was a typo in one of the attribute names, as well as I have merged two other small bugfixes from other forks of Twital. Would you like me to open a few separate PRs for those, as well?
from twital.
Related Issues (20)
- HTML5SourceAdapter ignores Doctype definition HOT 4
- Unnecessary escaping in attributes HOT 13
- Attributes are duplicated multiple nodes HOT 3
- Removed empty attribute HOT 3
- Missing SourceEvent HOT 1
- Add support fo JSX syntax and React components HOT 2
- How to make an child template be valid XHTML HOT 2
- Symfony 3 support HOT 3
- Add attribute with no value? HOT 3
- Still cannot add attribute with no value. HOT 1
- Documentation for t:content ? HOT 1
- Infinite loop with FixHtmlEntitiesInExpressionSubscriber HOT 5
- Append/Prepend Options For t:block HOT 1
- Question: own twig-functions don´t work HOT 13
- Docs are down
- Request new Release w/ updated deps (masterminds/html5) HOT 1
- Tag a new version for Twig 3 HOT 1
- Twital not working within blocks HOT 4
- Creation of dynamic property Goetas\Twital\Twital::$options is deprecated PHP 8.2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twital.