Git Product home page Git Product logo

Comments (3)

soukicz avatar soukicz commented on June 27, 2024

I have created this quick patch but i don't like very much that placeholder:

use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Goetas\Twital\EventDispatcher\SourceEvent;
use Goetas\Twital\EventDispatcher\TemplateEvent;

class CompatibilitySubscriber implements EventSubscriberInterface {
    const PLACEHOLDER = 'placeholderXXX###===';

    public static function getSubscribedEvents() {
        return [
            'compiler.pre_dump' => [
                ['valueAddPlaceholder']
            ],
            'compiler.post_dump' => [
                ['valueRemovePlaceholder']
            ],
        ];
    }

    public function valueAddPlaceholder(TemplateEvent $event) {
        $doc = $event->getTemplate()->getDocument();

        $xp = new \DOMXPath($doc);
        $xp->registerNamespace('xh', 'http://www.w3.org/1999/xhtml');

        /**
         * @var $option \DOMElement
         */
        foreach ($xp->query("//xh:option[@value='']") as $option) {
            $option->setAttribute('value', self::PLACEHOLDER);
        }
    }

    public function valueRemovePlaceholder(SourceEvent $event) {
        $event->setTemplate(str_replace(
                ' value="' . self::PLACEHOLDER . '"',
                ' value=""',
                $event->getTemplate())
        );
    }
}

from twital.

goetas avatar goetas commented on June 27, 2024

It should be an https://github.com/Masterminds/html5-php issue.. i will check it

from twital.

goetas avatar goetas commented on June 27, 2024

See Masterminds/html5-php#84, it will be fixed soon

from twital.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.