Unnecessary escaping in attributes about twital HOT 13 CLOSED

This could be solved be enabling FullCompatibilityTwigExtension, but that would enable less strict syntax.

from twital.

Is is working correctly with ContextAwareEscapingSubscriber disabled

from twital.

hi! the right syntax for your code should be:

<img t:attr=" true ? src='/a/x.jpg' ">

See http://twital.readthedocs.org/en/latest/tags/attr.html

from twital.

The syntax used by you should work only with FullCompatibilityTwigExtension enabled. Does it work?

from twital.

I realize that, but it would require rewrite large amount of template code before migration and FullCompatibilityTwigExtension enables a lot of others things.

It is also inconsistent:

<img src="{%if true%}/a/x.jpg{%endif%}">
{# output <img src="%2Fa%2Fx.jpg"> #}

<img src="{{ true ? '/a/x.jpg' }}">
{# output <img src="/a/x.jpg"> #}

from twital.

It make sense, i Will take a look

from twital.

The will be probably somewhere in ContextAwareEscapingSubscriber (esapeUrls?) but I can't find specific place.

from twital.

I'm unable to reproduce the issue (see branch escaping test case I22Test).

Feel free to fork it and create a failing test case.

from twital.

any news in this?

from twital.

@Soukiii ping

from twital.

I am using this test for my quick&dirty fix:

public function testAttributes() {
        $this->assertHtml('<img src="/a/x.jpg">', '<img src="{{a}}">', ['a' => '/a/x.jpg']);
        $this->assertHtml('<img src="/b/x.jpg">', '<img src="{{ true ? "/b/x.jpg"}}">');
        $this->assertHtml('<img src="/c/x.jpg">', '<img src="{%if true%}/c/x.jpg{%endif%}">');
        $this->assertHtml('<img src="/d/x.jpg">', '<img src="{%if true%}{{a}}{%else%}{{b}}{%endif%}">', ['a' => '/d/x.jpg', 'b' => '/b/x.jpg']);
    }

I will try to look at it later.

from twital.

added test https://github.com/goetas/twital/commits/master no way to reproduce

from twital.

These test were definitely failing with master version which means that you fixed it with some other changes.

from twital.