Comments (2)
peterbourgon
commented on August 25, 2024
I think we've decided to punt on this problem, and say that the DefaultCaller will only ever work in With, and that users are expected to manage their own call stack depth with log.Caller(n) outside of With. @ChrisHines, if you agree, I think we can close this issue.
from kit.
ChrisHines
commented on August 25, 2024
@peterbourgon I agree, although remember that this issue is about all log.Valuers, not just log.Caller.
Nonetheless, I think when we replaced log.With with log.Context it became easier to understand the scoping of Valuers. Let's make sure the docs clearly indicate that connection and then we can close this issue.
from kit.
Related Issues (20)
- License violation in metrics/teststat/populate.go HOT 3
- hystrix pkg don't support fallback func HOT 3
- Stackoverflow CC-SA License Violation HOT 2
- Support for overriding ErrorHandler in httputil.ReverseProxy HOT 1
- nats-io/jwt/v2 & nats-io/nats-server/v2 vulnerability issues CVE-2021-3127 & CVE-2022-24450 HOT 1
- [NATS transport] Support for headers in EncodeJSONResponse HOT 6
- Upgrade to prometheus/client_golang 1.12.2 HOT 4
- Security vuln CVE-2019-19794 with transitive dependency github.com/miekg/[email protected] HOT 1
- Fix security vulnerability CVE-2022-41717 exposed by Go gRPC dependency HOT 1
- Nats Jetstream transport HOT 1
- Could you create a new release tag with the upgraded package HOT 5
- Vulnerability of dependency "golang.org/x/net, golang.org/x/text, github.com/nats-io/nats-server/v2"
- Security vuln CVE-2022-34038 affecting go etcd client HOT 1
- otelkit was removed from opentelemetry-go-contrib HOT 1
- Add Error Handling for Canceled Contexts during request lifecycle HOT 3
- New security vulnerabilities found in multiple direct and indirect third-party dependencies
- UDP as a transport HOT 1
- http.EncodeJSONResponse body writing is not compatible with net/http HOT 2
- Update usage of deprecated io/ioutil library HOT 1
- Potential issue with Counter internal slice management
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kit.