Comments (4)
How do you want to leverage the new features? Do you want to use them in Go kit code or your own code?
from kit.
In a consuming application (celestiaorg/celestia-core) I wanted to use counter.Inc()
which I thought was only available in 1.12.2 (here) but it also appears available in 1.11.1 (here). So I investigated this codebase a little more and learned that my feature request would imply adding Inc()
to
Lines 5 to 8 in 50c3826
and this method may not be applicable to counters for other packages in https://github.com/go-kit/kit/tree/50c38262a8c71be2532f45100e622025bc5ffedf/metrics
Do you have thoughts here? It's likely that this issue can be closed as not planned
from kit.
Feel free to add a PR that adds Inc to Counter, but it's not obvious to me that
c.Inc() // is better than
c.Add(1) // in any meaningful sense
from kit.
Said another way,
I'd like to leverage new features in prometheus/client_golang 1.12.2. Are there any objections to upgrading this dependency?
You don't need to upgrade the dependency to use the new features. So I guess I'll close this for now.
from kit.
Related Issues (20)
- Kafka transport implementation HOT 4
- Consul Implementation of Instancer spams Consul and pushes consul agents to 100% CPU HOT 3
- prometheus/client_golang vulneravility issue
- License violation in metrics/teststat/populate.go HOT 3
- hystrix pkg don't support fallback func HOT 3
- Stackoverflow CC-SA License Violation HOT 2
- Support for overriding ErrorHandler in httputil.ReverseProxy HOT 1
- nats-io/jwt/v2 & nats-io/nats-server/v2 vulnerability issues CVE-2021-3127 & CVE-2022-24450 HOT 1
- [NATS transport] Support for headers in EncodeJSONResponse HOT 6
- Security vuln CVE-2019-19794 with transitive dependency github.com/miekg/[email protected] HOT 1
- Fix security vulnerability CVE-2022-41717 exposed by Go gRPC dependency HOT 1
- Nats Jetstream transport HOT 1
- Could you create a new release tag with the upgraded package HOT 5
- Vulnerability of dependency "golang.org/x/net, golang.org/x/text, github.com/nats-io/nats-server/v2"
- Security vuln CVE-2022-34038 affecting go etcd client HOT 1
- otelkit was removed from opentelemetry-go-contrib HOT 1
- Add Error Handling for Canceled Contexts during request lifecycle HOT 3
- New security vulnerabilities found in multiple direct and indirect third-party dependencies
- UDP as a transport HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kit.