Mismatch of the tutorial section of stringsvc example and its full code about kit HOT 6 OPEN

https://github.com/go-kit/go-kit.github.io

from kit.

Can you enumerate some of them? I am happy to fix them.

from kit.

Can you enumerate some of them? I am happy to fix them.

Thanks Peter!

• First of all, in the tutorial section of stringsvc3, there is no context while in the github code(ex:proxying.go) there is. It seems that the advance topic of the tutorial section is also included in stringsvc3.
• Line 51 of the proxying.go is
  e = ratelimit.NewErroringLimiter(rate.NewLimiter(rate.Every(time.Second), qps))(e), but in the tutorial is
  e = kitratelimit.NewTokenBucketLimiter(jujuratelimit.NewBucketWithRate(float64(maxQPS), int64(maxQPS)))(e). Actually, jujuratelimit is not imported at all in the full code.
• Line 44 of the the same file is endpointer sd.FixedEndpointer, but in the tutorial is
  subscriber sd.FixedSubscriber. Thus in line 52, you can see endpointer = append(endpointer, e), while in the tutorial is subscriber = append(subscriber, e) and of course the same mismatch in line 57 where there is balancer := lb.NewRoundRobin(endpointer) but in the toturial is balancer := lb.NewRoundRobin(subscriber)

from kit.

can i work on this too? @peterbourgon

from kit.

Yeah, go for it. Haven't gotten to it.

from kit.

@peterbourgon great. where can I find the html files for https://gokit.io/examples/stringsvc.html#calling-other-services, and how do I know which file is more recent? should I just play around with them?

from kit.