Git Product home page Git Product logo

Comments (5)

giannif avatar giannif commented on June 3, 2024 1

@josvegit ah! I see. Thanks for the logs 👍 There's an actual error parsing the data. I don't think the request is valid even though it returns a 200. Can you make sure you're passing a string to giphyFetch.search(search), it's typed as any and it looks like in the request the value for q (as in query) is q%5Bsearch%5D. It should be something like q=dogs

from giphy-js.

giannif avatar giannif commented on June 3, 2024

@josvegit I'm going to look at when I show that message first thing tomorrow. I think it shows if there are no gifs, which isn't really an error, just no results, making this a UI problem

If you fetch gifs and there are results, everything is okay?

If this helps, here is a codesandbox demonstrating a search for dog gifs:
https://codesandbox.io/s/giphyreact-components-hbmcf?from-embed

from giphy-js.

giannif avatar giannif commented on June 3, 2024

@josvegit I can't seem to make sense of this, you can see in this line that the error state is only set when the fetch throws:
https://github.com/Giphy/giphy-js/blob/master/packages/react-components/src/components/grid.tsx#L116

Maybe you can add a handler onGifsFetchError and see what the error is.
Also, just making sure you're on the latest version which is 0.3.7

from giphy-js.

josvegit avatar josvegit commented on June 3, 2024

Console logged the error from onGifsFetchError

Screenshot from 2020-02-07 20-17-15

Also getting a warning from the console

Screenshot from 2020-02-07 20-18-19

from giphy-js.

josvegit avatar josvegit commented on June 3, 2024

aah thanks, my bad !

from giphy-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.