Comments (5)
@josvegit ah! I see. Thanks for the logs 👍 There's an actual error parsing the data. I don't think the request is valid even though it returns a 200
. Can you make sure you're passing a string
to giphyFetch.search(search)
, it's typed as any
and it looks like in the request the value for q
(as in query) is q%5Bsearch%5D
. It should be something like q=dogs
from giphy-js.
@josvegit I'm going to look at when I show that message first thing tomorrow. I think it shows if there are no gifs, which isn't really an error, just no results, making this a UI problem
If you fetch gifs and there are results, everything is okay?
If this helps, here is a codesandbox demonstrating a search for dog gifs:
https://codesandbox.io/s/giphyreact-components-hbmcf?from-embed
from giphy-js.
@josvegit I can't seem to make sense of this, you can see in this line that the error state is only set when the fetch throws:
https://github.com/Giphy/giphy-js/blob/master/packages/react-components/src/components/grid.tsx#L116
Maybe you can add a handler onGifsFetchError
and see what the error is.
Also, just making sure you're on the latest version which is 0.3.7
from giphy-js.
Console logged the error from onGifsFetchError
Also getting a warning from the console
from giphy-js.
aah thanks, my bad !
from giphy-js.
Related Issues (20)
- Support for ES6 Modules HOT 3
- How to pick the format having only the id? HOT 3
- Gif does not support keypress event HOT 3
- At Grid component: "Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method." HOT 1
- Add support for AbortController HOT 1
- Consider making pingback and remote fonts configurable HOT 4
- Why there is no 'clips' type? HOT 1
- Carousel does not pass noLink property HOT 1
- Giphy React Grid component is not working HOT 4
- Please upgrade to react18 HOT 5
- SearchBar component make search button optional HOT 2
- Giphy/react-components 5.13.0 corporate proxy issue HOT 1
- renderGrid gifs positions are not set properly in lit HOT 2
- Focused Gif is not visually emphasized HOT 4
- Remove Grid not working HOT 1
- `require` in ESM build HOT 2
- `SyntaxError: Named export 'appendGiphySDKRequestHeader' not found. The requested module '@giphy/js-util' is a CommonJS module, which may not support all module.exports as named exports.` HOT 2
- It is advised to avoid ship styled-components in the build bundle. HOT 5
- React logging errors similar to "React does not recognize the `isFirstLoad` prop on a DOM element." HOT 1
- Next.js build fails: "Module not found: Can't resolve 'styled-components'" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from giphy-js.