Support for ES6 Modules about giphy-js HOT 3 CLOSED

Maybe useful reading reading on the subject: https://blog.logrocket.com/publishing-node-modules-typescript-es-modules/

from giphy-js.

@rockwotj this has been on my list for awhile, I'll see if I can get it in our queue

from giphy-js.

I'm not sure whether it's relevant to this discussion or not, but since the issue mentions side effects, I thought I'd just mention it briefly. Importing Grid from @giphy/react-components indeed has potentially critical side effects. It imports Gif, which creates a const GifContainer = styled.div... at import time, which eventually caches document.head to insert <style> tags into. However, if the import is executed at an inconvenient time (e.g. before document is mounted in an Electron app), document.head doesn't exist yet which results in an error.

In my specific case, trying to add a Gif picker to the Signal Desktop client, that means the app is caused in an infinite loading screen unless the entire import is delayed until the picker is actually rendered. For more details (such as the exact error message), see my comment in the emotion repository: emotion-js/emotion#2919 (comment).

from giphy-js.