geoadmin / mf-geoadmin3 Goto Github PK

1: VISTA IE9
2: Steps to reproduce
http://mf-geoadmin3.bgdi.admin.ch/main/prod/
zoom to Luzern
OPen a share function

3: Result
external Share functions opens in same window
4: Expected Result
opens in new window as in RE2

5: if possible: workaround
none, and if you hit the back button it does not take you to the last location...

See discussion: https://github.com/geoadmin/mf-geoadmin3/pull/185/files#r5469674

Locales JSON files are loaded after the execution of the link function of the ImportKML directive.

we need a "load KML" in the UI as we have it in RE2 ....

Some components (gaLayers service and the users of this service) should act if the language changes (loading new layers.json, loading new catalog, etc). Therefore, we should broadcast a message when the language changes.

On the event topic change, one should change the available langs, according to the values in the topic listing service.

The arrow keys don't work there anymore because they are captured by the map for panning.

This can be seen in share panel (in the embed text area or in the edit box), but also in dialogs like kml import.

I don't think that's the desired behaviour.

All in the title with this JS error
Uncaught TypeError: Object # has no method 'getResolutionForExtent'
But it works in src mode

In Import WMS component parsing of some WMS GetCapabilities failed:

ol3 problems?

The plovr version used to build the openlayers build is not compatible with the java version installed on mf1lt. We have version 6 installed, and we need 7 for plovr.

1: VISTA IE9
2: Steps to reproduce
Cold load application http://mf-geoadmin3.bgdi.admin.ch/main/prod/
3: Result
non translated technical names appear on load in container
4: Expected Result
Application does show correct language on load.
Otherwise user thinks application is slow. This can especially observed on older mobile and slow connections... I know it is picky, but it is the first thing the user sees fomr the new app ... I think jeiziner observed the same thing

5: if possible: workaround
WAIT!
6: link to file : attache it to github

The tumb in the result list is useless and the zoomToExtent on mouse over/out is disturbing.

So we should remove the thumb column amd replace it by a zoomToExtent column.

On page load, invalid tiles (ending with -1.jpeg) are loaded

The CSS rules that position the zoom bar within the map are specific to the application and don't produce good results in the map component example.

See #240 (comment)

In http://mobile.map.geo.admin.ch/?mobile=true#mobile=true&lang=de&zoom=2&scale=2499995&X=152391.24362&Y=538224.29422&bgLayer=ch.swisstopo.pixelkarte-farbe&bgOpacity=1&geolocation=false (test on chrome), you can observe a geolocation permalink parameter.

Could you please make that RE3 supports also this parameter (it means that the geolocation control is active (true) or not active (false, default value)
Thanks !

See https://groups.google.com/d/msg/re3-dev/6Ln4IjkAsLg/xRMUlNa61FcJ for more details.

1: VISTA IE9
2: Steps to reproduce
http://mf-geoadmin3.bgdi.admin.ch/main/prod/
change lang
3: Result
backgroudn switcher is on a new line
4: Expected Result
same line

5: if possible: workaround
reload app/ cold start

They should be links to be keyboard accessible.

←, ↑, →, ↓, +, - are unusable in every field as they are catched to control the map.

They shouldn’t be catched (at least) when a link/button/input/select/textarea is focused.

In the Makefile, we have a few sections that are absolutely similar but the 'mode=prod'. Maybe we can improve that to avoid errors and follow the DRY principle more closely.

As an example, compare target prod/index.htmland src/index.html

Let it empty as in RE2

make updateol
cd .build-artefacts/ol3; git fetch origin; git merge --ff origin/master; git show; ../python-venv/bin/python build.py build/ol.js build/ol-simple.js build/ol-whitespace.js
Already up-to-date.
2013-07-25 10:50:45,177 build/ol.js: java -jar build/plovr-2013-rc3.jar build buildcfg/ol.json
Exception in thread "main" java.lang.UnsupportedClassVersionError: org/plovr/cli/Main : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
Could not find the main class: org.plovr.cli.Main. Program will exit.
Traceback (most recent call last):
File "build.py", line 747, in
main()
File "/home/sbrunner/mf-geoadmin3/.build-artefacts/ol3/pake.py", line 339, in main
target.build(dry_run=options.dry_run)
File "/home/sbrunner/mf-geoadmin3/.build-artefacts/ol3/pake.py", line 107, in build
self.action(self)
File "build.py", line 191, in build_ol_js
t.output('%(JAVA)s', '-jar', PLOVR_JAR, 'build', 'buildcfg/ol.json')
File "/home/sbrunner/mf-geoadmin3/.build-artefacts/ol3/pake.py", line 190, in output
output = check_output(args, *kwargs)
File "/home/sbrunner/mf-geoadmin3/.build-artefacts/ol3/pake.py", line 38, in check_output
raise subprocess.CalledProcessError(retcode, cmd, output=output)
TypeError: init() got an unexpected keyword argument 'output'
make: ** [updateol] Error 1

PR #6 provided a way to parse the query string to set the application's initial states. Now we need to do the reverse, that is create links from the application's current states.

One way to do it is to simply update the URL in the address bar. Angular's $location service supports that, based on the HTML5 History API. This service has a fallback mechanism for browsers that don't support the History API (IE9 in our case), but I haven't tested it yet.

Here's a demo: http://mf-geoadmin30t.bgdi.admin.ch/elemoine. The URL in the address bar should change as the map view changes. (I introduced a 1 second delay for performance reasons).

The commit that implements this is here: 097d863.

1: VISTA IE9
2: Steps to reproduce
http://mf-geoadmin3.bgdi.admin.ch/main/prod/
Activate geolocation
let app zoom to your location
try to pan with left mouse hold
3: Result
no panning but zooming! (zoombar does not work neither)
4: Expected Result
panning works as defined
5: if possible: workaround
none
and even after deactivation of geolocationthe app is not usable anymore. Seems to be an issue: pan with left mouseclick impossible, scrollwheel starts panning as well-> complete reload needed

When a share functions is activated it makes no sense to have geolocation=true in the send URL

ALL OS

ther is the geolcation button missing
use the Button as in slide 35 of https://docs.google.com/file/d/0B_gmqEgDEiu5UmpIWmJZMnpDNFU/edit?usp=sharing

The same applies fo 6.2.3 conetxt button Sahre with fadenkreuz (and yes we need to change the name (Share position)

#183
#186

In ImportWMS and Geolocation directives we need the view2D.getResolutionForExtent function.

Where can we put this stuff to avoid duplicate code.

Same question can be asked for code copied from Angular (URL_REG_EXP ...).

SCRIPT5022: AssertionError: Assertion failed
ol-whitespace.js, Ligne 2168 Caractère 3

For example: http://mf-geoadmin30i.bgdi.admin.ch/main/app/?bgLayer=ch.swisstopo.swissimage&X=195130.35&Y=571693.09&zoom=12

The existing examples don't work on IE9. @oterral found out it's because of <base href="../../../"> in the head tag of the html page. IE9 does not support relative pathes here.

1: VISTA IE9
2: Steps to reproduce
http://mf-geoadmin3.bgdi.admin.ch/main/prod/
zoom to http://mf-geoadmin3.bgdi.admin.ch/main/prod/?topic=inspire&lang=de&bgLayer=ch.swisstopo.pixelkarte-farbe&X=176450.93&Y=861536.08&zoom=13
activate Geolocation
3: Result
Takes forever to fly to the location or app even crashes (amdin.ch is not responding due to a long-running script))
4: Expected Result
as smooth as in ffirefox
5: if possible: workaround
none

In general the fly to is too slow on VISTA (tested with safri,chrome ff)

As discussed during our weekly hangout.

The file contains value with \' which is not valid.
scripts/translation2js.py needs to be fixed

We're loading too much of bootstrap

We currently fetch WMTS capabilities with an Ajax request to http://wmts.geo.admin.ch/1.0.0/WMTSCapabilities.xml. We rely on CORS for that, which IE 9 does not support.

Since 87081cd the tests are run twice on Travis. make all run them, and Travis does npm test, which runs them again. make all should probably be what we want to do on Travis - make is our entry point.

We use the x- prefix for x-ga-background-layer-selector and x-ga-map for not for ga-context-menu. We don't have to use it, but we need to be consistent.

1: VISTA IE9
2: Steps to reproduce
http://mf-geoadmin3.bgdi.admin.ch/main/prod/
zoom in with mousewheel, continue zoomeing when your at the end
3: Result
zooming continues
4: Expected Result
zooming stops at end level

5: if possible: workaround
none
6: link to file :

The ContextMenu will not pop up when one of the underlying services (height, transform, qrcode) is not responding/not working.

IMO, this should be more forgiving.

1: VISTA IE9
2: Steps to reproduce
http://mf-geoadmin3.bgdi.admin.ch/main/prod/
go to lucerne
share QR
context QR
open on iphone
3: Result
location is not correct
4: Expected Result
correct location as in re2
5: if possible: workaround
6: link to file : attache it to github

1: VISTA IE9 and WIN8
2: Steps to reproduce
http://mf-geoadmin3.bgdi.admin.ch/main/prod/
open KML window
enter
http://dl.dropbox.com/u/44486020/swisstopo.kml

3: Result
Parsing ok appears in window but no dataset in the maps
4: Expected Result
replace parsing ok with "Loading ok..."
Make Icon visible
5: if possible: workaround
none