Git Product home page Git Product logo

Comments (5)

elemoine avatar elemoine commented on May 14, 2024

I can work on that on Friday, if no one else takes this on, and if the other works on the permalink panel are done.

from mf-geoadmin3.

elemoine avatar elemoine commented on May 14, 2024

I'm actually no longer sure about that. Sorry. I now tend to think that it makes sense to have a "permalink" feature which is just a service that directives like "map", "contextmenu" et "permalinkpanel" use.

What I don't like is the name "permalinkpanel". A component named "share" would make more sense to me.

And talking about names, I think I'd rename "contextmenu" to "contextpopup" or something. What we're displaying on contextmenu events is not a menu really.

from mf-geoadmin3.

gjn avatar gjn commented on May 14, 2024

+1 on all accounts.

from mf-geoadmin3.

cedricmoullet avatar cedricmoullet commented on May 14, 2024

+1 from me as well

On Fri, Jul 12, 2013 at 9:43 AM, Gilbert Jeiziner
[email protected]:

+1 on all accounts.


Reply to this email directly or view it on GitHubhttps://github.com//issues/109#issuecomment-20862792
.

Twitter: http://twitter.com/cedricmoullet
Linked In: http://www.linkedin.com/in/cedricmoullet

http://twitter.com/cedricmoullet

from mf-geoadmin3.

cedricmoullet avatar cedricmoullet commented on May 14, 2024

All has been addressed in the mentionned PR's

from mf-geoadmin3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.