Comments (7)
if you run eslint
outside of import-js, does it then pick up the undefined jsx variables? This has been a problem on and off since I added import-all. The eslint call depends on the .eslintrc.js to be in good shape. I think it might have to do with having eslint 2 installed and our config using eslint 1 specific config:
'ecmaFeatures': {
'jsx': true
},
in eslint 2, this is
{
"parserOptions": {
"ecmaFeatures": {
"jsx": true
}
}
}
But I'm not actually sure. It doesn't work for me either, and I have eslint 1.10.1 installed.
from import-js.
Yep, it does catch it when just running eslint
outside of import-js. -_-
from import-js.
Is it possible that you have two different eslint
s installed and that a different one is run in import-js vs outside of import-js?
from import-js.
It turns out that we broke this a while ago in de3c9ee.
Look at what eslint outputs for the Ripple
not being defined:
68:22 error "contextualEventHelper" is not defined no-undef
159:8 error 'Ripple' is not defined react/jsx-no-undef
217:11 error "contextualEventHelper" is not defined no-undef
The jsx plugin puts the variable in single quotes. I'll fix this and publish a new version soon.
from import-js.
Ah! My bad. I'll look into submitting a PR to the React plugin to make this consistent with ESLint.
from import-js.
Ah, that would be great!
from import-js.
Actually, it seems that most ESLint rules use single quotes. So perhaps I'll submit a PR over there instead.
from import-js.
Related Issues (20)
- Support for jsconfig.json HOT 7
- Option to import with double quotes instead of single quotes HOT 2
- Lodash alias doesn't work HOT 3
- groupImports ends up grouping namedExports separately. HOT 1
- Import maps HOT 2
- active forks HOT 3
- Unable to import files when using smart pipeline operator HOT 5
- Fails to install: node-pre-gyp? HOT 4
- when i move a personal module file to an other folder, the import suggestion of the personal module propose the old folder and the new folder HOT 2
- Config file can't be loaded inside an ES Module project HOT 1
- Move away from Flow? HOT 14
- Move to Prettier, abandon ESlint HOT 4
- Cleaning up stale issues & PRs HOT 2
- Abandon old node versions, update test matrix HOT 2
- React Imports on JSX HOT 1
- Reintroduce some ESlint rules
- Better schema validation errors
- Auto-generate configuration documentation
- Add plugin support HOT 2
- Missing CODECLIMATE_REPO_TOKEN for Github Actions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from import-js.