Git Product home page Git Product logo

Comments (7)

coagmano avatar coagmano commented on June 7, 2024 1

I've gotten around it by putting the package.json and node_modules in /src, which doesn't work for create react app...

Should be relatively easy to add to here:
https://github.com/Galooshi/import-js/blob/master/lib/findProjectRoot.js

If you wanted to start a proposal

from import-js.

trotzig avatar trotzig commented on June 7, 2024

@mnieber Could you give a more specific example? What's the location of the file you're importing into and what's the location of the file/module you're importing? What did you expect import statements to look like vs what do they end up looking like?

Depending on the scenario here, you could look into using https://github.com/Galooshi/import-js#importstatementformatter.

from import-js.

mnieber avatar mnieber commented on June 7, 2024

I've found a solution based on an undocumented feature: the .importjs-root file. Just like package.json this file indicates the root directory for import paths found by importjs. By placing both .importjs-root and .importjs.js in the src directory, I managed to get import paths that do not start with the src/ prefix.
Maybe it's worth documenting .importjs-root?

from import-js.

mnieber avatar mnieber commented on June 7, 2024

Unfortunately, my solution (described above) is not adequate because now node_modules is no longer considered.

from import-js.

JoaquimEsteves avatar JoaquimEsteves commented on June 7, 2024

I know this is an old issue, but this is a feature I'd quite like to see.

A pet peeve of mine is that JavaScript projects always end up with hundreds of config files; and jsconfig has emerged as a bit of a standard.

I'd like to work on a PR, but I'm not experienced with the codebase, and would appreciate any hints as to where to look.

from import-js.

mnieber avatar mnieber commented on June 7, 2024

FYI, I'm now using the vandelay plugin in VSCode to generate the import statements. It doesn't have the "Fix all imports" feature that ImportJS has, which is very useful, but otherwise works really well.

from import-js.

mikabytes avatar mikabytes commented on June 7, 2024

I couldn't reproduce this issue. Perhaps it's been solved?

Here's what I did:

mkdir /tmp/test ; cd /tmp/test
npx create-react-app .
echo "export default 'hello'" > src/b.js
echo "console.log(b)" >> src/App.js
importjs fix src/App.js

ImportJS then went ahead and added this line:

import b from "./b.js";

Notice that it did not include the src in the path.

I'll go ahead and close this now as I can't reproduce the issue. However, if you feel I missed something then please go ahead and reopen it and describe how to reproduce step-by-step. Thanks!

from import-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.