Git Product home page Git Product logo

Comments (4)

lencioni avatar lencioni commented on May 18, 2024

Actually, relative paths might not be working for me at all in this project.

from import-js.

trotzig avatar trotzig commented on May 18, 2024

Is this the same project that didn't have lookup_paths? I think we have something that checks if import_path.start_with?(lookup_path), which won't work for paths starting with .. We should probably address that by stripping out any dots from the start of lookup paths. It's likely that someone will add e.g. ./app/assets here too, which will suffer from the same problem.

from import-js.

trotzig avatar trotzig commented on May 18, 2024

This was the line I was talking about: 994f70d#diff-ca39607eaaa0631db83ec644bad6bab0R49

Though it was checking make_relative_to instead of import_path, but the result is the same.

from import-js.

lencioni avatar lencioni commented on May 18, 2024

Yes, this is the same project that didn't have lookup_paths.

from import-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.