Git Product home page Git Product logo

Comments (4)

lencioni avatar lencioni commented on May 17, 2024

One bummer about this is that it would introduce a dependency on eslint-plugin-react.

from import-js.

lencioni avatar lencioni commented on May 17, 2024

I guess the dependency wouldn't be too bad if this was off by default, and enabled as an option.

from import-js.

trotzig avatar trotzig commented on May 17, 2024

Wouldn't it be enough to grep for "'React' must be in scope when using JSX (react/react-in-jsx-scope) [javascript/eslint]" or something? You're right in that it creates a dependency, but it's very soft. We don't even need a config option for that, we can just casually look for it. :)

from import-js.

lencioni avatar lencioni commented on May 17, 2024

Yes I think so, but that would require that the eslint-plugin-react package is installed and the rule is enabled in the local .eslintrc file which seems probably okay but less than ideal--partly because it is different than what we do for the other two rules that we depend on for this functionality.

from import-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.