foldfelis / displaystructure.jl Goto Github PK

@JuliaRegistrator register

For loops' performance here, here, and here, can be accelerated.

minor advice: this loop can be remove by array operations.
for example

len = index.pre + index.post + 1
old_len = length(row.context)
new_len = old_len + len
resize!(row.context, new_len)
copyto!(row.context, index.i + len, row.context, index.i, old_len - index.i + 1)
fill!(@view(row.context[index.i:index.i+len]), row.background)

(correctness need to be checked)

_Originally posted by @chengchingwen in #3

Hello
Thanks for nice package.

I've noticed that you already support borderless Rectangle but those option is not accessble from Panel

I've made this commit to pass kwargs to the Rectangle from the Panel
YongHee-Kim@87a56dd

here is MWE

using DisplayStructure
DisplayStructure.Panel("TestPanel", [5,12],[1,1];background = '.', border = false) |> render

@JuliaRegistrator register

Release notes:

New APIs!

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!