Found the issue when one of the extracted file used a path longer than the Windows limit (around 260 characters).

When used on windows with path ./ only files starting with . are added to the zip file instead of the whole folder.
Probably because of the command used for windows:
powershell.exe -nologo -noprofile -command "& { Add-Type -A 'System.IO.Compression.FileSystem'; [IO.Compression.ZipFile]::CreateFromDirectory('${inPath}', '${outPath}'); }"

I'm not sure if this is a bug or intended behavior, but in my app I'm using both unzip and zip to first unpack a zip file, then modify its contents, and finally zip all the files again.

Since unzip takes a zip file containing files ./a.txt and ./b.txt and puts them into the directory ./example, I expected zip to take the files ./example/a.txt and ./example/a.txt and put them into the zip file as ./a.txt and ./b.txt. That's not the case, however, as the ./example directory is included in the zip file and there's seemingly no way to put files at the root of the zip file (and recreate the original zip).

Is there a way to do this? (I'm using cross-zip v2.1.6 on Linux.)

Per #19 (comment), the Powershell command does not handle paths with spaces in them. Here is the error output from a run in Travis CI/Windows:

https://travis-ci.com/malept/cross-zip/jobs/286009985#L81

And the test code that causes it:

https://github.com/malept/cross-zip/blob/a349ed0f8e439fc91b1368318659f52750a5d645/test/unzip.js#L44-L65

Using unzip as documented produces the following message after completion. I was able to correct the error by adding a callback as a third parameter for the unzip. Is this just missing in the documentation, or is there a better way to make it work?

Original Code

var zip = require('cross-zip'); zip.unzip('./test.zip', './tmp');

Produces:

C:\Users\Paul\AppData\Roaming\npm\node_modules\cross-zip\index.js:87
cb(err)
^

TypeError: cb is not a function
at C:\Users\Paul\AppData\Roaming\npm\node_modules\cross-zip\index.js:87:5
at ChildProcess.exithandler (child_process.js:194:7)
at emitTwo (events.js:87:13)
at ChildProcess.emit (events.js:172:7)
at maybeClose (internal/child_process.js:817:16)
at Socket. (internal/child_process.js:319:11)
at emitOne (events.js:77:13)
at Socket.emit (events.js:169:7)
at Pipe._onclose (net.js:469:12)

Correct and Functional Code

var zip = require('cross-zip'); zip.unzip('./test.zip', './tmp', function() { console.log("done"); });

Produces:

done

Hi,

I'm using cross-zip on Windows 10 and I'm experiencing an issue where it believes the file is "corrupted" in certain situations.

The zips are creating using an NPM script, so I have both cross-zip and cross-zip-cli installed:

cross-var cross-zip build dist/$npm_package_name-$npm_package_version.production.zip

The zip is created in the directory but I get the following issues when trying to use the zip:

• 

• I also get the following error message from Chrome when trying to drag and drop the zip into the chrome://extensions page: "Failed to load extension from: <path>. Could not unzip extension for install."

There was a suggestion, in an issue on the Mozilla Addons repository, that it could relate to the behaviour of the System.IO.Compression.ZipFile class.

Do you know if there is anything that can be done?

EDIT:

I attempted to put all files at the top level of the zip, but this still did not allow the zip to be loaded in Chrome

exude

Execute the OS specific command.

Lately I noticed you are into cross OS commands, I think exude will be useful, if yes I am happy to help!

I had .NET 4.6 installed as well as PowerShell. However, I got the following error:

Add-Type : Cannot add type. The assembly 'System.IO.Compression.FileSystem' could not be found.

I found lots of posts saying you need .NET 4.5 or greater -- not helpful -- and some dusty old forum post saying you need PowerShell 3. I installed that and now it works.

BTW the difference between Windows and Unix here is pretty funny.

Linux and Mac:

• zip -r swag.zip folder

Windows:

• Install .NET Framework 4.5 from some 100MB download
• Install Powershell 3.0 as part of "Windows Management Framework 3.0" from 2012
• powershell.exe -nologo -noprofile -command "& { Add-Type -A 'System.IO.Compression.FileSystem'; [IO.Compression.ZipFile]::CreateFromDirectory('folder', 'wtf.zip'); }"
• ... or you can do it all out of the box, but only by manual point and click. Ridiculous

Can cause remote code execution if there is a code path to an attacker-supplied filename.

POC (Windows): put ' in filename.

POC (Other): put space or & or | in filename.

Since this library is the access point for shell execution, it's this library's responsibility to mangle file paths for the shell, not the caller's responsibility.

On macOS, zip -r -y does not synchronize deletions with an existing zip archive.

You need --filesync or -FS for that behavior.

It seems that node-unzip and node-tar use pure Javascript to do the job.
I worry about their efficiency.

• For some reason, the default charset encoding of my system is not utf-8, and other people couldn't unzip the file generated on my computer. So I suggest specify the encoding to utf-8 explicitly.

function getZipCommand (inPath, outPath) {
  if (process.platform === 'win32') {
    return `powershell.exe -nologo -noprofile -command "& { Add-Type -A 'System.IO.Compression.FileSystem'; Add-Type -A 'System.Text.Encoding'; [IO.Compression.ZipFile]::CreateFromDirectory('${inPath}', '${outPath}', '${1}', '${true}', [System.Text.Encoding]::UTF8 ); }"`
  } else {
    var dirPath = path.dirname(inPath)
    var fileName = path.basename(inPath)
    return `cd ${JSON.stringify(dirPath)} && zip -r -y ${JSON.stringify(outPath)} ${JSON.stringify(fileName)}`
  }
}