Git Product home page Git Product logo

Comments (5)

toyobayashi avatar toyobayashi commented on July 19, 2024

@shroudedcode I met the same issue. I have a fork and have fixed it. @tybys/cross-zip

from cross-zip.

shroudedcode avatar shroudedcode commented on July 19, 2024

@toyobayashi Thanks for such a great fork! I'm now using it in apk-mitm.

from cross-zip.

feross avatar feross commented on July 19, 2024

@toyobayashi Can you send a PR to integrate your fixes into this package?

from cross-zip.

toyobayashi avatar toyobayashi commented on July 19, 2024

@feross But this package has been almost completely rewritten in my fork, with API breaking change. Should I merge the latest code into another branch then do some fix?

from cross-zip.

feross avatar feross commented on July 19, 2024

Ah, okay. If the code has changed that much then it's probably not worth it. I was just interested in getting the bug fixed with the parent folder being included.

from cross-zip.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.