fergusgriggs / fegaria-remastered Goto Github PK

Hey, I found your project on Pygame and went to run it because it looks cool- but I'm having trouble. In the current implementation there are no installation instructions for Fegaria-Remastered, so I went ahead and tried to install all the imports and launch it like that. But I ran into the hiccup of not being able to find the package perlin anywhere. I suggest adding some documentation to the README.md on how to install and launch your game.

~# easy_install perlin
Searching for perlin
Reading https://pypi.python.org/simple/perlin/
Couldn't find index page for 'perlin' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
No local packages or working download links found for perlin
error: Could not find suitable distribution for Requirement.parse('perlin')

Thanks,
Seth

when i click 2 or use the sword a lot the game stops crashes and the error is in the file in fegra_remasterd.py i cant play the game with this bug

Hi there,

When I started playing, the lighting was making all of the blocks black, with no distinction between what block is what.

Experimental lighting on:

Experimental Lighting off:

As for the objects, door sprites are invisible or cutoff, and so are pot sprites:

The GOD SLAYER (Excalibur), and dropped items have a purple box to appear around it:
https://user-images.githubusercontent.com/104463569/229185922-b0b18177-3bfb-4f3e-a63d-5776d8c1ab00.mov

Do you think adding multiplayer?

Chests, whenever opened, has a weird behavior whenever you place an item on the third and fourth row, When placing an item on the third row, the item's icon appear on the second row while the item can be clicked and retrieved on the third row. and you cannot even place something on the fourth row.
As a fix, I recommend changing lines 564 & 565 on fegaria_remastered.py from
slot_x = chest_index % 10
slot_y = chest_index // 10
to
slot_x = chest_index % 5
slot_y = chest_index // 5
Ice, on the other hand, disappears (and consumes the item) whenever it is placed, It's as if the ice turns to air so I suspected that there's something wrong in the ice's properties in the xml file.
I recommend changing line 10 on item_data.xml from
<item id="7" id_str="fg.item.ice" name="Ice" desc="It's icy cold" tags="tile" image_path="res/images/items/ice.png" tier="0" max_stack="999" buy_price="5" sell_price="0" tile_id_str="fg.tile.air" pickup_sound="fg.sound.grab" drop_sound="fg.sound.grab" hold_offset="0.0"></item>
to
<item id="7" id_str="fg.item.ice" name="Ice" desc="It's icy cold" tags="tile,material" image_path="res/images/items/ice.png" tier="0" max_stack="999" buy_price="5" sell_price="0" tile_id_str="fg.tile.ice" pickup_sound="fg.sound.grab" drop_sound="fg.sound.grab" hold_offset="0.0"></item>

I've been going through the codebase a bit to do a refactor so as to make updating easier, if you're interested.

From what I figure out from your code, you run a lot of threads - Threads in python do not work like they do in C or something, something called GIL exists in python that essentially only allowes one thread of the interpreter to run at any given time. So, making a lot of threads does not increase performance at all, in fact it is the other way. The only usecase for threads in python is when you are doing IO related stuff that do not use much CPU.