fastify / point-of-view Goto Github PK

Getting the following error when rendering a view using the [email protected] engine:

{
  "level": 50,
  "time": 1545039516427,
  "msg": "cb is not a function",
  "pid": 5396,
  "hostname": "goliatorum.home",
  "reqId": 1,
  "req": {
    "id": 1,
    "method": "GET",
    "url": "/login",
    "hostname": "127.0.0.1:3003",
    "remoteAddress": "127.0.0.1",
    "remotePort": 53826
  },
  "res": { "statusCode": 500 },
  "err": {
    "type": "TypeError",
    "message": "cb is not a function",
    "stack": "TypeError: cb is not a function\n    at Function.compile (/src/node_modules/ejs-mate/lib/index.js:130:3)\n    at _readCallback (/src/node_modules/point-of-view/index.js:139:39)\n    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:528:3)"
  },
  "v": 1
}

This is due to ejs-mate expecting a callback in their compile function:

function compile(file, options, cb) 

• point-of-view: 2.1.0

Missing type-definition for typescript usage. Will try to help with that.

The devDependency fastify was updated from 2.12.0 to 2.12.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

fastify is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I think test.js is becoming very hard to maintain as there is a lot of duplicated code. I think we should split into multiple files and create some helpers to reduce code duplication as much as possible.

I recently migrated my app from express to fastlify. It's awesome what it did performance wise 👍

I'm using Handlebars as my view engine, using a layouts/main.hbs which has all the boilerplate code. (Head, Loading Spinner, etc.)
But how can I configure point-of-view to use the main layout by default?
I tried it using all options with no success...

The devDependency nunjucks was updated from 3.1.3 to 3.1.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nunjucks is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I think it's due that we improve the support for async/await in this module.

Currently, it's not working as expected mainly because loading templates could be asynchronous, and that does not work well with the internal call to .send(), as there is no way to await that.

It following should work with any template engine.

What we need as next steps is a proposal to implement an API that could be awaited upon, and then an implementation.

Before you submit an issue we recommend you drop into the Gitter community or Fastify Help and ask any questions you have or mention any problems you've had getting started with Fastify.

Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here that does not follow the instructions, your issue might be closed,
locked, and assigned the missing discussion label.

🚀 Feature Proposal

Make the data-parameter of .view(page, data) for all template-engines optional.

I already created the corresponding PR #131.

This seems to catch up to the PR #52.

Motivation

I use the view-function often with implicitly provided data via the defaultContext. Currently this efforts in any case (than the pure ejs-template-handler) that an empty objeckt ({}) must be provided.

Since the pure ejs-view-function treats the data-parameter already as optional, i expected it to be optional for the other template-engines, too.

Example

Current syntax

  fastify.register(require('../index'), {
    engine: {
      'ejs-mate': require('ejs-mate')
    },
    defaultContext: { text: 'text' },
    templates: 'templates'
  })

  fastify.get('/', (req, reply) => {
    reply.view('index.ejs', {})
  })

Future syntax

  fastify.register(require('../index'), {
    engine: {
      'ejs-mate': require('ejs-mate')
    },
    defaultContext: { text: 'text' },
    templates: 'templates'
  })

  fastify.get('/', (req, reply) => {
    reply.view('index.ejs')
  })

Handlebars engine very commonly uses the extension ".hbs", although point-of-view is not configure for it.

The ejs link in your README is pointing to a spam site. I believe the correct URL is now https://ejs.co/

layout is optional for some template engines.
So it's supposed to be under options as others.

If there are no objections I'll take a stab at a PR.

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 3.1.1 of nunjucks was just published.

This version is covered by your current version range and after updating it in your project the build failed.

nunjucks is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency @types/node was updated from 11.10.4 to 11.10.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Before you submit an issue we recommend you drop into the Gitter community or Fastify Help and ask any questions you have or mention any problems you've had getting started with Fastify.

Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here that does not follow the instructions, your issue might be closed,
locked, and assigned the missing discussion label.

🐛 Bug Report

A clear and concise description of what the bug is.

this.header return undefined
so "message": "Cannot read property 'send' of undefined"

change to:
this.header('Content-Type', 'text/html; charset=' + charset)
this.send(html)

To Reproduce

Steps to reproduce the behavior:

Paste your code here:

this.header('Content-Type', 'text/html; charset=' + charset)
this.send(html)

The devDependency nunjucks was updated from 3.1.7 to 3.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nunjucks is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hi all,
I just see that a new release of Nunjucks is available, so could be good to use it.
See here.
And update other dependencies too, but keep Fastify to pre-1.0.x (0.43.0), ok ?

{
  engine: {
    njk: require('nunjucks')
  }
}

Not working.

Version 1.11.2 of fastify was just published.

This version is covered by your current version range and after updating it in your project the build failed.

fastify is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

When referring to the wrong variable, express gets an exception rather than hangs, but when fastify, it causes the entire program to die.

Hi all,
for consistency with Fastify (and with some other core plugins) I think could be useful to change the devDependency from 'request' to latest 'simple-get', and maybe update all other dependencies ...
What do you think ?
If accepted, I'll do a PR with changes (even related tests of course).

Thanks, Sandro

The actual options for getHeader is not compliant to the fastify codebase that support the chaining-call:

ex: this.header('Content-Type', 'text/html; charset=' + charset).send(html)

It would be awsome if @momofan or @florianb could work on this 💪

Mode info on how to implement this improvement:

They are replicating the core Reply methods and should behave accordingly. In fact, I'm not sure why the view decoration is on the server object. Views should be rendered in the context of a request, and in particular the context of sending a reply. So I would think the view decoration should be fastify.decorateReply('view', function () {}). Which would mean the following would be an outline of a solution:

fastify.decorateReply('view', function () {
  // other details omitted
  renderer.apply({getHeader, header}, args)

  function getHeader (key) {
    return this.getHeader(key)
  }

  function header (key, val) {
    return this.header(key, val)
  }
})

Originally posted by @jsumners in #129

Version 1.11.0 of fastify was just published.

This version is covered by your current version range and after updating it in your project the build failed.

fastify is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

App.register(require('point-of-view'), { engine: { pug: require('pug') }, options:{}, templates: 'templates' })

I got :
Error: the "filename" option is required to use includes and extends with "relative" paths
in the file :

extends ./layout.pug block content p hola

How I pass filename to options object inside the configuration ?

Version 4.4.0 of marko just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As marko is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

hello, i tried to include my header and footer but it doesn't works
how can i include it in my file

Here's my declaration

here's my folder structure

i tried to import like this
<% include views/admin/header %>

and get error like this
{"statusCode":500,"error":"Internal Server Error","message":"Could not find the include file "views/admin/header""}

Why is the data argument required? In my application I have several templates who don't need any variables for example.

hey there- I recently started playing around with Fastify, so excuse me if i just missed something before making this issue.

I have a use case where i want to output xml (rss feed). The rss template is actually in a pug template. This is just because it's easier to work with.
So the flow is-- I go get my data, set the content-type with reply.header('Content-Type', 'text/xml'); then call view() with the template and my data.

The expectation is that i'll end up with an xml response. What actually happens is that the content-type gets overridden when you call view() with a template-
https://github.com/fastify/point-of-view/blob/master/index.js#L53

I'm curious if there's a specific reason behind this? Or if it's acceptable to check for a content-type defined, and not assign text/html if there is one?

Version 4.12.0 of marko was just published.

This version is covered by your current version range and after updating it in your project the build failed.

marko is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Error: fastify-plugin - expected '^1.1.0' fastify version, '2.0.0' is installed

If/when someone have time,

😄 🐭 🧀

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 2.84.0 of request was just published.

This version is covered by your current version range and after updating it in your project the build failed.

request is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Is it possible to build in support for twig.js?
link: https://github.com/twigjs/twig.js

The devDependency marko was updated from 4.14.22 to 4.14.23.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

marko is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

I'm working on transitioning an Express app to Fastify. Here's my server code:

const fastify = require("fastify")();
const handlebars = require("handlebars");
const log = console.log; // eslint-disable-line

fastify.register(require("point-of-view"), {
  engine: {
    handlebars: handlebars
  },
  templates: `${__dirname}/views`
});

fastify.get("/", async (request, reply) => {
  reply.view("/home.html", { body: `<p>Cool</p>` });
});

const start = async () => {
  try {
    await fastify.listen(process.env.PORT || 8080, process.env.IP || "0.0.0.0");
  } catch (err) {
    fastify.log.error(err);
    process.exit(1);
  }

  log(`Server listening on ${fastify.server.address().port}`);
}

start();

This is in my home.html template:

<!DOCTYPE html>
<html lang="en">
  {{> views/head }}

  <body class="home">
    {{> views/navigation }}

    <main>
      {{{ body }}}
    </main>

    {{> views/footer }}
  </body>
</html>

The error message I get is "The partial views/head could not be found". The thing is though, views/head.html exists. Nothing I have tried is working.

I’ve made a reduced test case at tigt/streaming-html-minifier-reduced-test-case.

If you comment out useHtmlMinifier and comment in useHtmlMinifyStream, the rendered HTML is not minified. However, for the reverse, it is. Am I doing something wrong?

i can only return json if i'm calling a promise inside the router, how do i do something like this?

i am creating amp pages so i cannot consume api from frontend, i'm using point-of-view to render the data on the layout.

fastify.get('*', function (req, res) {
    return new Promise(function (resolve) {
      axios.get(`/contents`).then(({data}) => {
        // res.view('blog/content', {
        //   data: data
        // });
        resolve() //what to resolve here?
      }, err => {
        res.code(404)
        resolve(res) //
      })
    })
  });

Hi all,
I just see that if I don't set in explicit way reply encoding, Firefox will complaint on missing encoding.
So for reply.view I need to do (anytime) something like:
reply.type('text/html; charset=utf-8').view('index', data)

What do you think on adding that encoding as default for views (could be a good default) ?
Or check the encoding of related view (file) ... but this could be too much and alittle more expensive in performances.

What do you think ?

Thanks,
Sandro

Calling reply.view in an async handler function logs an error:

{"level":50,"time":1541536966444,"msg":"Promise may not be fulfilled with 'undefined' when statusCode is not 204","pid":17183,"hostname":"ip-10-10-10-218.ec2.internal","reqId":1,"err":{"type":"Error","message":"Promise may not be fulfilled with 'undefined' when statusCode is not 204","stack":"Error: Promise may not be fulfilled with 'undefined' when statusCode is not 204\n    at /home/steve/ff-pov/node_modules/fastify/lib/wrapThenable.js:18:34"},"v":1}

The rendered html will actually arrive at the browser, but the above message will be logged to console.

Here is example server:

const fastify = require("fastify")({
  logger: true
});

fastify.register(require("point-of-view"), {
  engine: {
    nunjucks: require("nunjucks")
  }
});

async function something() {
  return new Promise((resolve, reject) => {
    setTimeout(() => {
      resolve(new Date());
    }, 1000);
  });
}

fastify.get("/", async (req, reply) => {
  const t = await something();
  reply.view("/home.html", { text: t });
});

fastify.listen(3000, err => {
  if (err) throw err;
  console.log(`server listening on ${fastify.server.address().port}`);
});

Is there a better way to do this?

I separate and registe rendering config in other file.

// marko_conf.js
const path = require("path");
module.exports = async (fastify, opts) => {
	fastify.register(require("point-of-view"), {
		engine: {
			marko: require("marko"),
		},
		includeViewExtension: false,
		templates: path.join(__dirname, "./templates")
	});
};

// app.js
const fastify = require("fastify")();

fastify.register(require("./marko_conf.js"));
fastify.get("/", (req, reply) => {
	reply.view("index.marko", { text: "hi" });
});

fastify.listen(3000);

/home/jimmy/Desktop/test/app.js:7
	reply.view("index.marko", { text: "hi" });
	      ^
TypeError: reply.view is not a function
    at Object.fastify.get (/home/jimmy/Desktop/test/app.js:7:8)
    at preHandlerCallback (/home/jimmy/Desktop/test/node_modules/fastify/lib/handleRequest.js:88:30)
    at handler (/home/jimmy/Desktop/test/node_modules/fastify/lib/handleRequest.js:72:5)
    at handleRequest (/home/jimmy/Desktop/test/node_modules/fastify/lib/handleRequest.js:22:5)
    at onRunMiddlewares (/home/jimmy/Desktop/test/node_modules/fastify/fastify.js:346:5)
    at middlewareCallback (/home/jimmy/Desktop/test/node_modules/fastify/fastify.js:334:7)
    at Object.routeHandler [as handler] (/home/jimmy/Desktop/test/node_modules/fastify/fastify.js:224:7)
    at Router.lookup (/home/jimmy/Desktop/test/node_modules/find-my-way/index.js:265:17)
    at Server.emit (events.js:180:13)
    at parserOnIncoming (_http_server.js:642:12)

but, if I regist in the same file that will work

The devDependency @types/node was updated from 13.7.6 to 13.7.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency tap was updated from 12.4.0 to 12.4.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

tap is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hi guys,

Have any of you got troubles with including other EJS components within an EJS file? I'm getting following error "Error: Could not find include include file.".

Example:
<% include header %> within the "index.ejs" file.

It works in Express, so maybe I just can't find the relative path somehow. All my ejs files is located in the same folder, so shouldn't be an issue.

Thanks.

Is multiple templates directory like the one below supported? Since some of the template engines supported allows extension of templates (template inheritance) from other templates (e.g. nunjucks).

root
└───modules
│   │   └───home
│   │   │   │   index.js
│   │   │   └───templates
│   │   │   │   └───home
│   │   │   │   │   │   home-template1.html (inherits from base.html)
│   │   │   │   │   │   home-template2.html (inherits from base.html)
│   │   └───about
│   │   │   │   index.js
│   │   │   └───templates
│   │   │   │   └───about
│   │   │   │   │   │   home-template1.html (inherits from base.html)
│   │   │   │   │   │   home-template2.html (inherits from base.html)
└───templates
│   │   base.html

Master

<!doctype html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
    <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css" integrity="sha384-ggOyR0iXCbMQv3Xipma34MD+dH/1fQ784/j6cY/iJTQUOhcWr7x9JvoRxT2MZw1T" crossorigin="anonymous">
    <title><%= title ? title : '' %> - Backbeard</title>
  </head>
  <body>
    <% include ../inc/navbar %>
    <div class="container">
      <%- body -%>
    </div>
    <script src="https://code.jquery.com/jquery-3.3.1.slim.min.js" integrity="sha384-q8i/X+965DzO0rT7abK41JStQIAqVgRVzpbzo5smXKp4YfRvH+8abtTE1Pi6jizo" crossorigin="anonymous"></script>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.14.7/umd/popper.min.js" integrity="sha384-UO2eT0CpHqdSJQ6hJty5KVphtPhzWj9WO1clHTMGa3JDZwrnQq4sF86dIHNDz0W1" crossorigin="anonymous"></script>
    <script src="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/js/bootstrap.min.js" integrity="sha384-JjSmVgyd0p3pXB1rRibZUAYoIIy6OrQ6VrjIEaFf/nJGzIxFDsf4x0xIM+B07jRM" crossorigin="anonymous"></script>
  </body>
</html>

Index

<% layout('layouts/master') -%>
<h1>I am the template</h1>

Route

fastify.get('/', async (request, reply) => {
    return await fastify.view('/index.ejs', { title: 'text' })
})

I also tried options like reply.view with and without async. I tried everything. I do not know what I do wrong

Hello,

I just want to render a page with variables. Passing getting the variables and passing them with res.send works fine but if I use res.view I get an error that the promise is not fulfilled. I am pretty new to Javascript and especially to async functions.

My code looks as follow:

exports.show = async (req, res) => {
	try {
		const [var1, var2] = await Promise.all([
			getUser(id),
			getInfo(id)
		])
		res.view("index.pug", {var1: var1, var2: var2})
	} catch {
		if (err) throw err
	}
}

What am I doing wrong?
Thanks

The devDependency marko was updated from 4.14.5 to 4.14.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

marko is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🐛 Bug Report

defaultContext property is missing in PointOfViewOptions interface in TypeScript declaration file index.d.ts although the property is described in the README