Git Product home page Git Product logo

Comments (4)

DarthGoon avatar DarthGoon commented on August 30, 2024
res
    .header('Content-Type', 'text/xml')
    //.send('<thing jhsdf="124">kjnvuhr</thing>');
    .view('rss.pug', { a bunch of data });

in the above code- I will get back a text/html response calling view. But if you swap the commented send with view, you'll get back an xml response.

from point-of-view.

delvedor avatar delvedor commented on August 30, 2024

Hi!
Thank you for using Fastify :)

Yes, we are setting the content type on 'text/html' because internally Fastify (if you didn't set a content-type) assumes that you are sending an 'application/json'.
So to supply a better usability of this module we decided to automatically add the content type, so you don't need to do:

reply.header('Content-Type', 'text/html').view('./template.pug', { data: 'data' })

Honestly I didn't think about your use case :)

Your suggestion is the actual solution:

if (!reply.res.getHeader('Content-Type')) {
  reply.header('Content-Type', 'text/html')
}

If you want you can do a PR, if not I'll do it :)

from point-of-view.

DarthGoon avatar DarthGoon commented on August 30, 2024

cool... i made a PR - #10

from point-of-view.

delvedor avatar delvedor commented on August 30, 2024

Closed by #10

from point-of-view.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.