invacost's Issues
probable starting and ending year data columns
I have added an error check for missing values when expandYearlyCosts is used. In doing this I found that only "Probable_starting_year_low_margin" and "Probable_ending_year_low_margin" have complete data. "Probable_...year" and "Probable..._year_high_margin" do not. Not sure if this should be part of the response to the user (i.e. explain why the data are missing).
Labeling of least squares regression
With the way you have implemented 'sandwich' on the least squares regression would it be more appropriate to call this something different on the plots and tables? "Weighted least squares regression"
Include accuracy assessment in model plots
Suggestion from reviewer in MEE: include accuracy assesments in model plots.
What should we include? RMSE? RMSE on calibration points only?
So far it is the only metric we have included as a goodness-of-fit metric is the RMSE, should we implement new ones? e.g. the median absolute-deviation?
adjustments to calculateRawCosts.R documentation
I cleaned up some errors here, specifically with regards to the returned lists. I also found the Note regarding "rawAvgCosts()" to be confusing, but wasn't sure how to adjust appropriately.
I had one additional comment, and that is that NAs are returned from "calculateAvgRawCosts()" when there is not data in a year range. This seems slightly at odds with the documentation which says: "Missing data for specific years will be considered as zero." (in Details).
No error reporting appeared necessary.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.