YAML Exception about device-detector-js HOT 16 CLOSED

I found the issue. There's a missing double quote at line 1067 in a fixture file coming from matomo. We'll need to fix it upstream in their repo.

from device-detector-js.

matomo-org/device-detector#6162

from device-detector-js.

That's great!! Looks like we need to wait for things to get patched upstream.

from device-detector-js.

@etienne-martin So how do you propose to fix it on our end?

from device-detector-js.

Since, the issue is in oss.yml file, do you suggest manual download, conversion and editing?

from device-detector-js.

Yes exactly

from device-detector-js.

Ok I managed to pull the latest fixtures in this branch https://github.com/etienne-martin/device-detector-js/tree/3.12.3

You can use my branch to work on the latest version.

There are a couple of tests that needs to be fixed before we can merge that into master.

from device-detector-js.

Great! I will check on the tests today.

from device-detector-js.

First 2 tests were failing. Currently 1 fixed. 1 remaining.

from device-detector-js.

What would you advice for these errors?

from device-detector-js.

Great, the other ones might be a little bit tricky to fix. They seem to be related to this change: matomo-org/device-detector@ce932a4#diff-3376e152ac4d378cf0bbf8d569e5213cR691

from device-detector-js.

Hmm..So it looks like they have changed the way of detection. 🤔

from device-detector-js.

@etienne-martin So do you think we need to change our core?

from device-detector-js.

Yeah they are using some kind of getBrowserFamily method that we don't have in the js version.

It's mapping certain browsers to a parent "Browser Family": https://github.com/matomo-org/device-detector/blob/ce932a4c6a0de4587e293c08abafebc7db1e02bd/Parser/Client/Browser.php#L274

from device-detector-js.

Hmm. So we need to modify our https://github.com/etienne-martin/device-detector-js/blob/master/src/parsers/client/browser.ts

from device-detector-js.

@etienne-martin https://github.com/whimsicaldreamer/device-detector-js/tree/core-update
Trying my luck with it.

Please review the changes being made into the above branch and let me know whether we are going in the correct path.

from device-detector-js.