Comments (9)
Exactly, we updated the up to 4.1.0, we need to continue the upgrade to 4.3.1.
I will try to do it next week
from device-detector-js.
Just FYI @etienne-martin, @jmaitrehenry:
In case you want to easily test if an issue is also on the upstream php device-detector, you can use my site here:
https://devicedetector.lw1.at
It should always return the detection results from the latest master branch of https://github.com/matomo-org/device-detector.
So if the output there is wrong, then it's a bug in upstream.
from device-detector-js.
Mozilla/5.0 (Linux; Android 9; AFTKA Build/PS7255; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/94.0.4606.118 Mobile Safari/537.36 cordova-amazon-fireos/3.4.0 AmazonWebAppPlatform/3.4.0;2.0
added to matomo-org/device-detector#6969
from device-detector-js.
I just released version 3 with your recent upgrade but it doesn't seem like it fixed #129.
I updated the demo to the latest version and tried with a Chromecast user-agent and it gets detected as Chrome Webview
.
from device-detector-js.
Great, thanks @Findus23
from device-detector-js.
I'm having problems with latest FireTV 4k Max detected as a phone, seems the latest version has a fix for it, is this close to release?
from device-detector-js.
Are you getting the correct result when using this site https://devicedetector.lw1.at ?
from device-detector-js.
no, I've copied the Amazon Fire TV 4k max user agent from the web app and using an emulator it's detected as a phone
here's the commit that fixes this issue which many of our customers are complaining about
matomo-org/device-detector@5d1fa40
here's the user agent so you can test (edited, corrected)
Mozilla/5.0 (Linux; Android 9; AFTKA Build/PS7255; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/94.0.4606.118 Mobile Safari/537.36 cordova-amazon-fireos/3.4.0 AmazonWebAppPlatform/3.4.0;2.0
from device-detector-js.
The latest version of matomo works fine with this user-agent:
Gibbon/2020.2.2.0/2020.2.2.0: Netflix/2020.2.2.0 (DEVTYPE=NFANDROID2-PRV-FIRETVSTICK2018; CERTVER=0)
Found it in their test fixture.
I haven't looked at the new regex introduced by matomo-org/device-detector@5d1fa40 to see what could cause yours to fail.
Even if we were to update the library with what's currently upstream, the user-agent you provided would still fail so you can report the issue at https://github.com/matomo-org/device-detector/issues if you think there's something wrong with the detection of that user-agent.
Once the issue is fixed upstream, we'll be able to pull these changes into the library. No guarantee that this will be done quickly however.
from device-detector-js.
Related Issues (20)
- New detection for iOS and macOS HOT 5
- Does not work on IPad 5,3 HOT 1
- Difference with ua-parser-js HOT 1
- Incorrect iPhone models for mobile user agents HOT 1
- Why does the ipad on version 13.1.3 define it as a Mac OS in the devtools in safari?
- Implement CDN file HOT 1
- Missed device types (typings) HOT 1
- New detection for chromecast HOT 1
- Can we also detect GPU? HOT 2
- Facebook messenger detected as Facebook HOT 1
- Provide mappings for caniuse HOT 4
- Windows 11 detected as Windows 10 HOT 5
- Upgrade to support Matomo Device Detector 6 HOT 2
- How can I use to detect device on website access? HOT 2
- Version parse error
- export declared with export = DeviceDetector; forces me to use 'allowSyntheticDefaultImports'
- Sync newest detections from matomo
- Performance issue HOT 2
- Upgrade to 4.3.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from device-detector-js.