Comments (5)
Yes, it would be a good addition to the lib. I thought the regexes would be too heavy but they weigh about 250kb, even less when gzipped. We can definitely send that over the wire.
We would also need to change the way the cache is implemented, maybe fallback to localstorage on the front end.
We can maybe use require-yml to replace fs.read
by bundling the yaml files directly in the bundle.
from device-detector-js.
So fs.read
was removed, the next step is to replace lru-cache
with something that works in both the browser and node.
After that I need to find a way to make lodash treeshakable.
from device-detector-js.
For lodash, that might do it
#20
from device-detector-js.
For the cache, an easier solution might be to only skip the cache when running in the browser, because it will mostly be used by the client to validate its own user agent, so we don't really need to cache the results
Also we care a little less about performance as it is running client-side
#21
from device-detector-js.
Thanks 🙌
from device-detector-js.
Related Issues (20)
- New detection for iOS and macOS HOT 5
- Does not work on IPad 5,3 HOT 1
- Difference with ua-parser-js HOT 1
- Incorrect iPhone models for mobile user agents HOT 1
- Why does the ipad on version 13.1.3 define it as a Mac OS in the devtools in safari?
- Implement CDN file HOT 1
- Missed device types (typings) HOT 1
- New detection for chromecast HOT 1
- Can we also detect GPU? HOT 2
- Upgrade to latests matomo-org/device-detector version HOT 9
- Facebook messenger detected as Facebook HOT 1
- Provide mappings for caniuse HOT 4
- Windows 11 detected as Windows 10 HOT 5
- Upgrade to support Matomo Device Detector 6 HOT 2
- How can I use to detect device on website access? HOT 2
- Version parse error
- export declared with export = DeviceDetector; forces me to use 'allowSyntheticDefaultImports'
- Sync newest detections from matomo
- Performance issue HOT 2
- Upgrade to 4.3.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from device-detector-js.