Git Product home page Git Product logo

Comments (5)

etienne-martin avatar etienne-martin commented on May 26, 2024

Yes, it would be a good addition to the lib. I thought the regexes would be too heavy but they weigh about 250kb, even less when gzipped. We can definitely send that over the wire.

We would also need to change the way the cache is implemented, maybe fallback to localstorage on the front end.

We can maybe use require-yml to replace fs.read by bundling the yaml files directly in the bundle.

from device-detector-js.

etienne-martin avatar etienne-martin commented on May 26, 2024

So fs.read was removed, the next step is to replace lru-cache with something that works in both the browser and node.

After that I need to find a way to make lodash treeshakable.

from device-detector-js.

AlexBeauchemin avatar AlexBeauchemin commented on May 26, 2024

For lodash, that might do it
#20

from device-detector-js.

AlexBeauchemin avatar AlexBeauchemin commented on May 26, 2024

For the cache, an easier solution might be to only skip the cache when running in the browser, because it will mostly be used by the client to validate its own user agent, so we don't really need to cache the results
Also we care a little less about performance as it is running client-side
#21

from device-detector-js.

etienne-martin avatar etienne-martin commented on May 26, 2024

Thanks 🙌

from device-detector-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.