ether / etherpad-lite-jquery-plugin Goto Github PK

the userName option does not have any effect, as it is not used to create the full IFRAME-URL yet. A
&userName=' + settings.userName + '
should solve this problem.

I host an etherpad server and use etherpad.js to put etherpad iframes into my website. Unfortunately, every time an iframe is loaded, the newlines (\n) get modified (generally, they increase in number). This doesn't happen if I just reload the pad on my server, so it seems to have something to do with the iframe, but I don't know what.

Do you have any idea about how this could be happening?

In the case that someone embeds the same pad twice on a page, you have two iframes with the same id, which results in invalid HTML, because each id on a web page must be unique.

It is much better to use class= instead.

See MediaWiki Code Review discussion https://www.mediawiki.org/wiki/Special:Code/MediaWiki/111263#c30869 .

https://github.com/ether/etherpad-lite/pull/1593/files

IE8 doesn't like the console.log line and refrains from loading embedded etherpads completely.After commenting out that line it loads the etherpad (if that is working).

see titel.

sticky chat, not sure if param exists for this in pad.js yet tho

Plugin options and parameter are a bit unclear to me.

The example puts true/false in quotation marks:

$('#examplePadBasic').pad({'padId':'test','showChat':'true'});

But the overview leaves out the quotation marks:

'showChat'         : false, // If you want to show the chat button or not

Which way is correct?

http://plugins.jquery.com/docs/package-manifest/

{
  "name": "etherpad",
  "title": "jQuery Etherpad",
  "description": "jQuery plugin for embedding Etherpad",
  "keywords": [
    "color",
    "animation"
  ],
  "version": "1.0.1",
  "author": {
    "name": "John McLear",
    "url": "https://github.com/ether/etherpad-lite-jquery-plugin"
  },
  "licenses": [
    {
      "type": "Apache 2"
    }
  ],
  "bugs": "https://github.com/ether/etherpad-lite-jquery-plugin/issues/",
  "homepage": "https://etherpad.org",
  "dependencies": {
    "jquery": ">=1.5"
  }
}

Why is this client plugin named jQuery? It has not much to do with jQuery. A name such as "Etherpad JS wrapper" or "Etherpad JS embedder" would be more suitable. This name is really misleading...

AFAIK it really only creates a wrapper

Additionally when one admin says to another one "Hey, I use the Etherpad jQuery plugin on my server XY." it is not clear at all that this is a client-side plugin. I'd rather think it is a plugin I can install on the server.
This is not only theoretical, I misunderstood it this way.

So you might rethink this name.

Can I suggest to provide some demos in a 'examples' folder? I had some issues while testing.

The getContents example didn't work for me:

$('#examplePadBasic').pad({'getContents':'exampleGetContents'});

I tried to hide the controls but that didn't work:

$('#examplePadBasic').pad({
  'padId':'test',
  'host'             : 'http://beta.etherpad.org', // the host and port of the Etherpad instance, by default the foundation will host your pads for you
  'baseUrl'          : '/p/', // The base URL of the pads
  'showControls'     : false, // If you want to show controls IE bold, italic, etc.
});    

I would like to create new pads from our webapp automatically without seeing the initial screen with the option to "Create new pad" or "Enter name" is it possible?

How can I access the readOnlyPadId from the client when I am embedding a pad?

I am developing an web app that will use Etherpad to provide collaborative editing capabilities for a close group of activists and part of the app is to store the readOnlyPadId so that if a another user that is not part of group loads the app, he/she will only see the content and not the editor.

this was merged into develop eplite so should go into jquery oplugin