In etherpad.js in the iframe, better use class= instead of id= about etherpad-lite-jquery-plugin HOT 6 CLOSED

I agree, I will fix this when I get some spare time. My time over the next few weeks will be dedicated to core prolly..

-----Original Message-----
From: Wikinaut [mailto:[email protected]]
Sent: 12 February 2012 20:57
To: John McLear
Subject: [etherpad-lite-jquery-plugin] In etherpad.js in the iframe, better use class= instead of id= (#8)

In the case that someone embeds the same pad twice on a page, you have two iframes with the same id, which results in invalid HTML, because each id on a web page must be unique.

It is much better to use class= instead.

Reply to this email directly or view it on GitHub:
https://github.com/johnyma22/etherpad-lite-jquery-plugin/issues/8
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

from etherpad-lite-jquery-plugin.

I tried to fix this quickly today, but it appears to more difficult than expected. For example: when you embed the same pad two times on a page using class=eframe-padid-xyz , there are several ids which have the same id= value (for example id='passwordinput') in the iframe content.

Currently I do not know, if this allowed, or not, and; there are more urgent things to be fixed.
Should be tagged as "minor (low priority ) bug - to be fixed later" or something similar.

from etherpad-lite-jquery-plugin.

Why would you want to embed the same pad on a page twice?

from etherpad-lite-jquery-plugin.

There is not a single reason for doing that, but with the MediaWiki Extension, users could embed the pad several times. It does not make sense, and I will program a mechanism which prevents this.

But just when enbedding a pad twice intentionally, and confirming that that works, i found, that at least id= in the iframe should be unique and to use class=eframe-hash is a semi-perfect solution for that isolated problem.

As mentioned: not urgent, not severe.

from etherpad-lite-jquery-plugin.

I agree, can you please submit the fix that you wrote for that?

-----Original Message-----
From: Wikinaut [mailto:[email protected]]
Sent: 18 February 2012 17:54
To: John McLear
Subject: Re: [etherpad-lite-jquery-plugin] In etherpad.js in the iframe, better use class= instead of id= (#8)

There is not a single reason for doing that, but with the MediaWiki Extension, users could embed the pad several times. It does not make sense, and I will program a mechanism which prevents this.

But just when enbedding a pad twice intentionally, and confirming that that works, i found, that at least id= in the iframe should be unique and to use class=eframe-hash is a semi-perfect solution for that isolated problem.

As mentioned: not urgent, not severe.

Reply to this email directly or view it on GitHub:
https://github.com/johnyma22/etherpad-lite-jquery-plugin/issues/8#issuecomment-4035825
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

from etherpad-lite-jquery-plugin.

Note that if you set the id on the iframe it uses that as a suffix to "epframe" IE

<div id="foo"></div>
Becomes
`

from etherpad-lite-jquery-plugin.