epinowcast / hashprng Goto Github PK

• add README
• add NEWS
• add contributing guidelines
• implement basic CI stuff
• add assorted badging and other CI reporting

@pearsonca seems like we both had the same idea and now there is a logo conflict that will need clearing up. Which do you prefer.

I understand the logic but I hate reading and typing hbmPRNG can we rename to hbmprng.

Is this in scope and do you/we want to move it into the organisation?

Worthwhile to add some benchmarking stuff?

We can save ourselves duplication effort if we switch to a recompiled vignette approach like this: https://github.com/epinowcast/epinowcast/blob/main/vignettes/precompile.R

I had a chat with Nick Davies at the pub the other day and apparently he is presenting some similar sounding work (using hashing to maintain seeds across counterfactuals) at epidemics. @pearsonca likely worth reaching out to him about this and seeing if there is a way to link up or at least talk more about the +/-s of both approaches.

• split: non-identity in "basic" vignette, with identity in "intermediate"
• basic vignette should focus on add-hbm-functions to your model => basics of how to assess consequence of adding them
• intermediate on use them for a more complex model + more comparisons
• switch to using data-raw => inst to precompute simulations pertinent to the vignette

The vignette currently hard codes 5 cores. This should really be clearly communicated to the user and be set at the beginning of the vignette.

See the usethis vignette for this. I don't have permissions to do this.

Should this package be using the enwtheme for the pkgdown website in _pkgdown.yml?

As it is already in its own configuration section it doesn't also need to be in suggests. Same goes for sysfonts.

I also see usethis in there which I wouldn't usually include.

• same salt, same event => same draws
• different salt, same event => different draws
• same salt, different event => different draws