The prismatic from emilhvitfeldt

Something like clr_alpha(col, alpha) that would translate alpha values to their hex version (e.g. https://gist.github.com/lopspower/03fb1cc0ac9f32ef38f4) and paste them to the end of the hex color code

Annotate where the matrices come from in colorblindness functions

https://twitter.com/ClausWilke/status/1175291317548568576

Release prismatic 1.1.1

Prepare for release:

Submit to CRAN:

usethis::use_version('patch')
devtools::submit_cran()
Approve email

Wait for CRAN...

Provide option of colorspace in clr_lighten/darken

https://twitter.com/ClausWilke/status/1175293836568014848

Use hcl instead of hsl?

I noticed that rotate() uses hsl rather than hcl, but my recollection is that hcl is more perceptually uniform, so I think it would be better to use hcl.

I was also surprised see that "HSL" is the default in clr_lighten() — I re-read the colorspace paper to check that I wasn't missing something, but I see:

HLS() (Hue-Lightness-Saturation) is another transformation of (s)RGB that tries to capture the perceptual axes. It does a somewhat better job but the dimensions are still strongly confounded. See Wikipedia (2019f) for more details.

Print color dataframes

Thank you for such a nice package, @EmilHvitfeldt! 🌈

I wonder if there is plan for adding a pretty_print() method for dataframes of colors?

Include text contrast function?

It's not a perfect match for this package, but it seems like a reasonable home:

rel_l <- function(x) {
  scale <- function(x) {
    ifelse(x <= 0.03928, x / 12.92, ((x + 0.055) / 1.055)^2.4)
  }
  rgb <- farver::decode_colour(x) / 255
  0.2126 * scale(rgb[, 1]) + 0.7152 * scale(rgb[, 2]) + 0.0722 * scale(rgb[, 3])
}
contrast_ratio <- function(x, y) {
  x_l <- rel_l(x)
  y_l <- rel_l(y)

  (pmax(x_l, y_l) + 0.05) / (pmin(x_l, y_l) + 0.05)
}

This implements the WCAG 2.0 colour contrast computation (https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html) which is useful for checking that colours have sufficient contrast to be easily readable.

Explain magic numbers in clr_grayscale

https://twitter.com/ClausWilke/status/1175294017086640128

tannerhelland.com/3643/grayscale-image-algorithm-vb6/

Feature request: UK spelling for colour

Thanks for making this! Looks great.

Would it be possible to have colour as an alias for color in this package?

Upkeep for prismatic

Pre-history

2020

usethis::use_package_doc()
Consider letting usethis manage your @importFrom directives here.
usethis::use_import_from() is handy for this.
usethis::use_testthat(3) and upgrade to 3e, testthat 3e vignette
Align the names of R/ files and test/ files for workflow happiness.
usethis::rename_files() can be helpful.

2021

usethis::use_tidy_dependencies()
usethis::use_tidy_github_actions() and update artisanal actions to use setup-r-dependencies
Remove check environments section from cran-comments.md
Bump required R version in DESCRIPTION to 3.4
Use lifecycle instead of artisanal deprecation messages, as described in Communicate lifecycle changes in your functions

Easy way to manipulate individual hcl axes?

Something like this maybe:

modify_hcl <- function(x, h, c, l) {
  hcl <- as.data.frame(farver::decode_colour(x, to = "hcl"))

  if (!missing(h)) {
    h <- eval(substitute(h), envir = hcl)
  } else {
    h <- hcl$h
  }
  if (!missing(c)) {
    c <- eval(substitute(c), envir = hcl)
  } else {
    c <- hcl$c
  }
  if (!missing(l)) {
    l <- eval(substitute(l), envir = hcl)
  } else {
    l <- hcl$l
  }
  
  farver::encode_colour(cbind(h, c, l), from = "hcl")
}

Idea is to make it easy to do (e.g.) modify_hcl(x, h = 25) or modify_hcl(x, h = h + 10)

Use crayon for printing if available

One thing that could be super neat would be to use crayon for colouring the background during printing. You could simply use it if it was available so you'd only need to have it in suggests

Release prismatic 0.2.0

Prepare for release:

Submit to CRAN:

usethis::use_version('minor')
devtools::submit_cran()
Approve email

Wait for CRAN...

Make `clr_` functions work within mutate?

hi friend! 👋 thanks for this package, it's very very useful!

right now it doesn't look like clr_lighten() and clr_darken() (maybe all of them? I'm only looking at the lighten/darken functions though) work well within a mutate, seemingly due to mismatch in length of the colour/shift arguments. curious if this is something you'd be open to supporting, or if I'm missing some way to do it! ty!

library(prismatic)
library(dplyr)

x <- c("#fbbcb8", "#bfdff6")
clr_darken(x)
#> <colors>
#> #CE170CFF #1B7BC0FF

# sad in mutate() though
colours <- tibble(color = x) %>%
  mutate(darker = clr_darken(color))
#> Error: Problem with `mutate()` input `darker`.
#> x The length of `col` must be positive.
#> ℹ Input `darker` is `clr_darken(color)`.

# rowwise() doesn't help much?
colours <- tibble(color = x) %>%
  rowwise() %>%
  mutate(darker = clr_darken(color))
#> Error: Problem with `mutate()` input `darker`.
#> x The length of `col` must be positive.
#> ℹ Input `darker` is `clr_darken(color)`.
#> ℹ The error occured in row 2.

usethis::use_version('patch')
devtools::submit_cran()
Approve email

Wait for CRAN...

Accepted 🎉
usethis::use_github_release()
usethis::use_dev_version(push = TRUE)

emilhvitfeldt / prismatic Goto Github PK

prismatic's People

Stargazers

Watchers

Forkers

prismatic's Issues

Recommend Projects

Recommend Topics

Recommend Org