Git Product home page Git Product logo

Comments (3)

jrowlingson avatar jrowlingson commented on May 24, 2024 1

It appears that this also affects attributeBindings.

from ember-native-class-codemod.

tylerturdenpants avatar tylerturdenpants commented on May 24, 2024

Im not sure it's just nest props... the example below also occurs

Given:

export default Component.extend({
	classNameBindings: [
		'drawerClosed:hidden'
	],

Result:

import Component from '@ember/component';

export default class Component extends Component {}

Expected:

export default class ResourceDrawer extends Component {
	@className('hidden')
	drawerClosed

from ember-native-class-codemod.

pzuraq avatar pzuraq commented on May 24, 2024

We've switched this over to use the @classNameBindings and @attributeBindings decorators. These are much more of a direct target for codemods, so hopefully we won't see issues like these again. Feel free to reopen if you see something!

from ember-native-class-codemod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.