Won't transform class with `actions` hash about ember-native-class-codemod HOT 4 OPEN

Did a bit more digging and it seems the codemod supports actions using ObjectMethod notation but not FunctionExpression.

Works

actions: {
  foo() {}
}

Doesn't work

actions: {
  foo: function() {}
}

I'll see about putting together a PR

Edit:
hmm weirdly i can't replicate this behaviour in the tests

from ember-native-class-codemod.

After some more playing around with it I'm getting inconsistent results with this. Some times it works fine, sometimes it does not.

from ember-native-class-codemod.

I've just come across the same issue. It seems this is because of the ignoreLeakingState option in the config. This looks like it only supports queryParams by default even though in the README it calls out queryParams and actions.

Ember Objects with objects or arrays as direct properties (actions and queryParams are the exception). See eslint-plugin-ember/avoid-leaking-state-in-ember-objects for more details.

Adding actions to ignoreLeakingState options does go a step further and do a migration but in my testing it looks like it translates to actions = { ... }

@gitKrystan should actions be added as a default option in ignoreLeakingState?

from ember-native-class-codemod.

IIRC adding something to ignoreLeakingState means it won't be transformed from an object literal. The actions hash is special-cased, as you found.

Are you seeing anything about this file in codemods.log?

from ember-native-class-codemod.