Git Product home page Git Product logo

Comments (2)

asakusuma avatar asakusuma commented on June 30, 2024

@elwayman02 to make sure I understand what you are proposing, you want to:

  1. Use the "MyClass.prototype.foo" syntax by default when converting a class in an addon
  2. Add an option to use the current behavior instead of the default "MyClass.prototype.foo" behavior

Is that correct? And if so, would you be ok with actually flipping the default so that "MyClass.prototype.foo" syntax is opt it? That way the change is not breaking.

from ember-native-class-codemod.

elwayman02 avatar elwayman02 commented on June 30, 2024

@asakusuma making it opt-in behavior doesn't actually make sense, because the current behavior is unsafe by default. If anything, the unsafe behavior should be the opt-in (hence the suggestion of creating a second codemod that can be run to aggressively maintain the current behavior). I don't think this is a breaking change at all, it's a bugfix.

from ember-native-class-codemod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.