class RouterRouter extends EmberRouter about ember-native-class-codemod HOT 4 CLOSED

What is the file name and type returned from the telemetry? As per the code we append the type to file name. This would happen if file name is router.js and telemetry type is router

I am not sure how much we can automate the class naming. Sometimes I think we should have a different codemod just to handle the naming of classes, given the different cases in naming an unnamed class 😄

from ember-native-class-codemod.

I think that falls within the domain of this codemod. We're trying to create the best experience possible for anyone updating an Ember app to to native class syntax, so figuring out the naming is part of that. This is something that should be scoped in nature, since Ember apps have strong conventions here. There are a finite number of edge cases to handle 😃

In this case, there is only one router.js, so we should ignore it. This was also a larger problem, because it transpiled to the following:

import { get } from '@ember/object';
import { scheduleOnce } from '@ember/runloop';
import { inject as service } from '@ember/service';
import EmberRouter from '@ember/routing/router';
import config from './config/environment';
import RouterScroll from 'ember-router-scroll';

class RouterRouter extends EmberRouter.extend(RouterScroll) {
}

Router.map(function() {
});

export default Router;

Which broke, since only one of the symbols was transformed.

from ember-native-class-codemod.

What I meant by creating different codemods is, separating the part of code which handles naming from ember-object and putting it in different location under the same ember-es6-class-codemod So that it can be run post ember-object transformations.

The other issue in the example ^^ is same as #54 where we do not transform all the symbols

from ember-native-class-codemod.

Ah, I think that would be reasonable, separate them out structurally. They probably don't have to be completely separate codemods, just functions run sequentially in the same codemod, e.g. after this: https://github.com/ember-codemods/ember-es6-class-codemod/blob/master/transforms/ember-object/index.js#L17

from ember-native-class-codemod.