Comments (5)
What are the errors? Ideally it should skip the file because the codmods do not handle ember-data
https://github.com/ember-codemods/ember-es6-class-codemod#unsupported-types
from ember-native-class-codemod.
Right, the codemod should handle Ember Data since we have decorators for model attributes and relationships.
from ember-native-class-codemod.
Yes, but I think thats the decision we took before starting. I think a new codemod ember-data
should be created under ember-es6-class-codemod
to handle the model attributes and relationships
from ember-native-class-codemod.
I think #72 may help give some context here, we can now wrap all non-standard macros so we can transform classes we previously could not. In the future, this won't even be necessary - once emberjs/ember.js#17548 lands and decorators are supported in Ember itself, all current computed property macros will be decorators, so we can remove any wrapComputed
calls.
In the meantime though, it is probably not ideal to have ember-data macros be wrapped each time, so I think we should add them to the transform.
from ember-native-class-codemod.
I see that Models are being converted in the current version but the attr
transforms and options are removed from the decorators.
Never mind, I was using ember-es6-class-codemod
. This works correctly in ember-native-class-codemod
.
I think It is confusing when there are two different codemods that do effectively the same thing. One should be marked as deprecated.
Thanks for the great work on this
from ember-native-class-codemod.
Related Issues (20)
- Does not match field "body"
- Error `Error: Evaluation failed: TypeError: Cannot convert undefined or null to object` HOT 1
- TypeError: Cannot read property 'process' of undefined HOT 4
- `queryParams` needs to be an array
- Error when encountering ArrowFunctionExpression in computed setter HOT 2
- Codemod mistakes `computed.equal` for a modifier HOT 2
- Convert classic fields to prototype fields instead of class fields when run against an addon HOT 2
- ReferenceError: regeneratorRuntime is not defined if using babel.config.json
- Puppeteer version is not compatible with M1 Macs HOT 1
- I am getting `Ember is not defined` errors in a lot of the files
- Produces class decorator usage with incorrect syntax HOT 1
- codemod is removing async from methods HOT 1
- Codemod still mis-handling boolean CLI args as strings HOT 1
- Error count doesnโt match log.
- Unmodified when running codemod HOT 4
- Won't transform class with `actions` hash HOT 4
- Codemod is not working HOT 5
- Transformation error (Received an unexpected value [object Object])
- Class private methods are not enabled. Please add `@babel/plugin-transform-private-methods` to your configuration HOT 3
- Error: `define is not defined` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-native-class-codemod.