Occurs error while resolving lazy injection: <div class="snippet-clipboard-content

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Circular dependency detected about zend-di-config HOT 3 CLOSED

yethee commented on May 24, 2024

Circular dependency detected

from zend-di-config.

Comments (3)

yethee commented on May 24, 2024 1

@elie29 thanks for fix and a new release!

from zend-di-config.

elie29 commented on May 24, 2024

@yethee thx for the report. I will check it tomorrow and give you my feedback.

from zend-di-config.

elie29 commented on May 24, 2024

@yethee well you are right. The problem is related to the dependencies ArrayDefinition and factory callable function:

Foo::class => function (ContainerInterface $c) {
    return new Foo($c->get('config')['key']);
}

When we have a callable through an ArrayDefintion, the callable is resolved automatically which in this case, leads to a circular dependency because the callable requires the config key from the container.

This issue could be resolved by using a factory class as follow:

class FooFactory
{
   public function __invoke(ContainerInterface $c)
   {
       return new Foo($c->get('config')['key']);
   }
}

$config = new Config([
   'key' => 'null',
   'dependencies' => [
       'factories' => [
           Foo::class => function (ContainerInterface $c) {
               return new Foo($c->get('config')['key']);
           },
       ],
   ],
]);

However, I prefer also removes the dependencies key from the definitions as they are already resolved and not needed any more:

private function addDefinitions(ContainerBuilder $builder): void
{
    $this->addServices();
    $this->addFactories();
    $this->addInvokables();
    $this->addAutowires();
    $this->addAliases();
    $this->addDelegators();

    /**
      * PHPDI ArrayDefinition would resolve all keys
      * or dependencies are already resolved
      */
    unset($this->definitions[$this::CONFIG]['dependencies']);

     $builder->addDefinitions($this->definitions);
}