Consider to change namespace about zend-di-config HOT 8 CLOSED

@thomasvargiu or maybe Zend\PhpDi\Config as we are bridging php-di

from zend-di-config.

I consider Zend\* namespace Zend proprietary, you should use something that own to you. That's also true that Zend probably will not release nothing with Zend\PhpDi namespace, but I still that a your own namespace would be better. In open source projects we are not extending anymore some other namespaces.

from zend-di-config.

I followed pimple and other bridge namespace. It was accepted and integrated to zend expressive installer.
However any namespace change would mean a version 3.1+ at least because it is considered a Break Change.

from zend-di-config.

@elie29 changing the namespace I think it's a big BC. Classes are public API's, if you change it, it's a BC.

Even if the common use is to add services to the configuration, anyone could use your ConfigBuilder or some other classes.

from zend-di-config.

I think in our case, it wouldn't be a big BC, you need to change just the container.php with zend expressive. It is the only place where you use Zend/DI/Config.
IMHO, I use Zend/PhpDi/Config as Zend/Pimple/Config. What do you think better then Elie/Zend/PhpDi/Config?

from zend-di-config.

@elie29 PHP libraries should use semver.
I usually add dependencies in composer.json with vendor/package:^1.0 and I expect to don't need changes if I do a composer update and vendor/package is updated to 1.1.

Changing the namespace means it isn't backward-compatible, that's why we should increase the major version.

For the namespace name, it's your choose. I just suggested to make your own namespace (you can use it even for other libraries), but you can just even use a simple namespace like ZendPhpDiConfig. I know, it's a very long name and I don't like neither, it was just an example :)

You can choose and make these changes, it should be easy.

from zend-di-config.

@thomasvargiu ok. I will tag these two issues v4 and try to resolve the #28 first. It will be certainly on a new branch.

from zend-di-config.

@thomasvargiu I have created two branches:

• branch 3.x created to support future release related to v3
• branch 4.0 where I changed the namesapece to Elie\Zend\DI\Config with the migration guide

I will close this issue and assign the #27 so you can add definitions key to the branch v4. Once done, we merge it with master branch.

from zend-di-config.