Git Product home page Git Product logo

Comments (9)

elie29 avatar elie29 commented on May 24, 2024

@thomasvargiu thank you for the proposal.

Do you want to do it so I assigne it to you?

from zend-di-config.

elie29 avatar elie29 commented on May 24, 2024

It occurs changes in: config, tests, Readme file and suggestion in composer for lazy dependencies

from zend-di-config.

thomasvargiu avatar thomasvargiu commented on May 24, 2024

@elie29 I could work on it. It's a missed feature, a reason why I tried php-di to move then back to zend-servicemanager with zend-di AoT.

I have just a question. I think IMHO that something not related to map zend-servicemanger configuration to php-di should be moved in another configuration key. What do you think?

from zend-di-config.

elie29 avatar elie29 commented on May 24, 2024

Well you are totally right. dependencies keys are mapped to zend service manager (except autowires). So we can have defintions key at the same level of dependencies and not inside it.

from zend-di-config.

elie29 avatar elie29 commented on May 24, 2024
return [
  'definitions' => [
    MyClass::class => DI\create(MyClass::class)->lazy(),
  ],
  'dependencies' => [],
];

from zend-di-config.

thomasvargiu avatar thomasvargiu commented on May 24, 2024

definitions is a common key. In the last years projects are using namespace keys as configuration key, so it would be better to use a class namespace to use as a key to avoid conflicts, something like:

return [
    Zend\DI\Config::class => [
        'definitions' => [],
    ],
];

But I think we should resolve #28 first, that's why I open it.

from zend-di-config.

elie29 avatar elie29 commented on May 24, 2024

Right! should we need for definitions inside the classname key?

from zend-di-config.

thomasvargiu avatar thomasvargiu commented on May 24, 2024

Yes, it's better to make all BC break changes in just one release, we don't need to release something today :)

I suggest to resolve #28 and this PR and release them in a single major release.

from zend-di-config.

elie29 avatar elie29 commented on May 24, 2024

@thomasvargiu 4.0 created.

from zend-di-config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.