Comments (9)
@thomasvargiu thank you for the proposal.
Do you want to do it so I assigne it to you?
from zend-di-config.
It occurs changes in: config, tests, Readme file and suggestion in composer for lazy dependencies
from zend-di-config.
@elie29 I could work on it. It's a missed feature, a reason why I tried php-di to move then back to zend-servicemanager with zend-di AoT.
I have just a question. I think IMHO that something not related to map zend-servicemanger configuration to php-di should be moved in another configuration key. What do you think?
from zend-di-config.
Well you are totally right. dependencies keys are mapped to zend service manager (except autowires). So we can have defintions key at the same level of dependencies and not inside it.
from zend-di-config.
return [
'definitions' => [
MyClass::class => DI\create(MyClass::class)->lazy(),
],
'dependencies' => [],
];
from zend-di-config.
definitions
is a common key. In the last years projects are using namespace keys as configuration key, so it would be better to use a class namespace to use as a key to avoid conflicts, something like:
return [
Zend\DI\Config::class => [
'definitions' => [],
],
];
But I think we should resolve #28 first, that's why I open it.
from zend-di-config.
Right! should we need for definitions inside the classname key?
from zend-di-config.
Yes, it's better to make all BC break changes in just one release, we don't need to release something today :)
I suggest to resolve #28 and this PR and release them in a single major release.
from zend-di-config.
@thomasvargiu 4.0 created.
from zend-di-config.
Related Issues (20)
- Use Expressive Skeleton installer with PHP-DI results in error? HOT 10
- Consider to change namespace HOT 8
- Zend\Di namespace HOT 4
- Update contributing.md document
- Add 7.3 support to travis
- Allow to disable use autowire
- Launch composer update HOT 1
- Circular dependency detected HOT 3
- Update composer HOT 2
- Make overridden delegator idempotent
- Delete container-interop/container-interop HOT 2
- migrate to laminas framework
- scalar constructor / property injection etc. HOT 1
- Compile with Delegators HOT 3
- migration to php 8 HOT 2
- Psalm (static analysis tool) integration instead of phpstan
- Support writing proxy classes to files HOT 5
- Container compilation and delegators HOT 3
- PHP8.1 Compatibility HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zend-di-config.