bookmarker's People
Forkers
ecsoft hongbo-miao weipengyang 1797890817 mac1-germany iwdeity qiannianhanbing oreineke bookmarktools tacitphoenix carlosbuenosvinos minxc yujiechuck twofish0319 hehuazheng denisfitz57 yakose happut newplayground zzpzbl kevinbrother minkeetan mojitooooooooo hjian lipingcoding davidalphafox tang8560 naoyuyan x534 ten8ciousb vaingmunybookmarker's Issues
Needs License file
I'm not sure only stating 'MIT' in the package.json qualifies this as open source.
won't work with the latest (v6.0.12) electron
Hi, I'm following the "book electron in action" in chapter 2 to create the bookmaker app, but it doesn't work. The "submit" button keeps disabled no matter what I input!
Then I clone this repo, it worked.
But if I changed the dependency from "electron": "^1.7.10" to "^6.0.12", the issue occurs again!
Listing 2.8 Adding script with Node.js global in the browser context: ./app/index.html
The code in Listing 2.8 doesn't work in newer versions of Electron (Electron 5 and above) since the default values for "nodeIntegration" and "contextIsolation" have changed. Set nodeIntegration to "true" and contextIsolation to "false" in webPreferences to successfully run it.
Code:
mainWindow = new BrowserWindow({ webPreferences: { nodeIntegration: true, contextIsolation: false } });
Incompatible with new Electron?
I update the Electron package to ^9.0.0.
The bookmarker is not work.
validateReponse is not used
The validateResponse function is not used in the fetch's api call chain which also mismatches the content of the book.
newLinkForm.addEventListener("submit", (event) => {
event.preventDefault();
const url = newLinkUrl.value;
fetch(url)
.then(validateResponse) // missing
.then((response) => response.text())
.then(parseResponse)
.then(findTitle)
.then(title => storeLink(title, url))
.then(clearForm)
.catch(error => handleError(error, url));
});
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.