eclipse-cdt-cloud / tsp-typescript-client Goto Github PK

This repo will need a quick update, to use node 18 (currently 16.x). Potential references to node version:

• GitHub workflows: add at least node 18 in the "matrix" (we may keep 16 for now).
• package.json "engines.node" version ranges may need updating. e.g. ">=16 <=20 " could work for now
• dockerfiles
• documentation, e.g. README, guides

The deserialization of TSP JSON strings to class objects that contains bigint fields are done using searialization and a so called Normalizer. This make sure that for example, timestamps are deserialized as bitint and not Number if they are small values.

It would be good to provide a utility that supports this for non-TSP classes.

This repo uses lerna 4.x, which is old and has several know security-related issues. It would be desirable to upgrade to a recent version. Alternatively, it seems lerna may not even be used, so removing it as a dependency would also work.

For reference, here's the lerna version used in upstream reposositories:

Theia: 7.1.1

Blueprint: 6.6.2

his repository has the same issue when publishing next than theia-trace-extenstion (see also eclipse-cdt-cloud/theia-trace-extension#842).

I saw a recent commit stating that the license was changed to MIT, and I noticed that this file has a different license, so maybe it was forgotten.

Similar to the Trace Extension, we need to set up Prettier to enforce code style for the tsp-typescript-client. This includes:

[ ] Setting up Prettier in the repo so contributors can format their commits.
[ ] Setting up Prettier in CI to enforce code style.
[ ] Format the source code with Prettier.
[ ] Add documentation for Prettier.
[ ] Add a .git-blame-ignore-revs file to ignore the formatting commit.

Similar to this issue.

Consumers of the TimeGraphRow, like tsp-data-provider.ts in theia-trace-extension must do this: (row as any).entryID to get the entryId, which gives lint errors as any types should be avoided. The client should be updated instead

PUT for experiments command should not use actions in payload (see below). To add or remove traces provide a list of traces UUIDs in the payload and the server needs to validate whether traces need to be added or removed from the experiment by comparing the lists of traces on the server and in the command.

At a minimum, a 3PP license check needs to be performed before any release of an Eclipse Foundation project component, but ideally it should be done for each PR before merging, to catch 3PPs with incompatible or unclear licenses as early as possible.

We have been working on a standalone nodejs wrapper for Eclipse Foundation's dash-licenses, that can be used to easily add 3PP license checks in JS/TS repositories:

https://github.com/eclipse-dash/nodejs-wrapper

We will soon have its first release to npm, and thereafter it can be easily be added as a devDependency and used in this repo and others in this organization.

If a server returns a request with no body, the call to response.json() will cause an uncaught exception: "Uncaught SyntaxError: Unexpected end of JSON input".

The line const json = await response.json() as T; in method performRequest() of rest-client.ts causes the exception.

I setup Travis but the deployment to NPM doesn't work. There seems to be some permission issue.

I also tried it with my account but I don't have permission either.

With the latest release the README of the repository has been published to the NPM registry [1]. However, that README is meant for developers that developing the tsp-typescript-client. The README for the on NPM is meant for adopters/users of the NPM packages and should contain usage information.

https://www.npmjs.com/package/tsp-typescript-client