TimeGraphRow has field entryId that is filled as entryID about tsp-typescript-client HOT 6 CLOSED

Actually, it seems a lot of classes' fields defined in the TspClient do not correspond to the values described in the trace server protocol: https://github.com/theia-ide/trace-server-protocol/blob/master/API.yaml

For instance, the state from the TspClient has a startTime and duration, while the TSP plans for start/end.

IIUC, these values should match perfectly, right? So both TspClient and trace server should be updated

from tsp-typescript-client.

Thank eslint for highlighting this ;-)

from tsp-typescript-client.

Yes, we need to align the TSP, server and client implementation

from tsp-typescript-client.

I'll start fixing this. Do we take the trace-server-protocol as the source of truth for this and fix the rest?

from tsp-typescript-client.

I'll start fixing this. Do we take the trace-server-protocol as the source of truth for this and fix the rest?

The code should reflect what the TSP defines. However, if a name doesn't fit or is not consistent, you can update the TSP as well and then align the code implementation.

from tsp-typescript-client.

First steps for fixing this:

Fix the trace server protocol: eclipse-cdt-cloud/trace-server-protocol#27

Make the trace server behave according to the spec: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/167256

from tsp-typescript-client.